Skip to content

common fixes for guava_version_upgrade#82

Open
AbhishekKumar9984 wants to merge 1 commit intocdapio:cs_guava_upgradefrom
cloudsufi:common3_guava_upgrade
Open

common fixes for guava_version_upgrade#82
AbhishekKumar9984 wants to merge 1 commit intocdapio:cs_guava_upgradefrom
cloudsufi:common3_guava_upgrade

Conversation

@AbhishekKumar9984
Copy link
Copy Markdown

Replace removed APIs:

Throwables.propagate() -> throw new RuntimeException(e)
InputSupplier (removed) -> use existing ContentProvider
Charsets.UTF_8 -> StandardCharsets.UTF_8
Objects.toStringHelper/firstNonNull -> MoreObjects equivalents
Objects.hashCode -> java.util.Objects.hash
startAndWait/stopAndWait -> startAsync().awaitRunning/stopAsync().awaitTerminated
Update ASM bytecode generation to use RuntimeException constructor
Fix header ordering in HttpRequestsTestBase

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Guava library to version 32.0.0-jre and refactors the codebase to replace deprecated or internal Guava utilities with standard Java APIs or modern Guava alternatives. Key changes include migrating from com.google.common.base.Charsets to java.nio.charset.StandardCharsets, replacing com.google.common.base.Objects with java.util.Objects or com.google.common.base.MoreObjects, and substituting Throwables.propagate with standard RuntimeException wrapping. Feedback suggests improving the ASM bytecode generation in FieldAccessorGenerator.java by using a more general exception type for local variables and simplifying the instruction sequence for exception instantiation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant