pdo: fix index access via CiA 301 parameter record indices#641
Closed
Babafewa wants to merge 1 commit intocanopen-python:masterfrom
Closed
pdo: fix index access via CiA 301 parameter record indices#641Babafewa wants to merge 1 commit intocanopen-python:masterfrom
Babafewa wants to merge 1 commit intocanopen-python:masterfrom
Conversation
Allow accessing TPDOs and RPDOs using their CiA 301 parameter record indices. Previously only sequential indices (1-512) worked. Extends the fix from PR canopen-python#613 to also cover RPDO communication records (0x1400-0x15FF) which were missed in that PR. Fixes canopen-python#607 Signed-off-by: babafewa olamide <babafewaolamide@gmail.com>
|
And no/closed because just no/closed? lol |
Member
|
@AjnusAfter Yes, LOL! Take a look around, for example at the actual state of upstream code when opening your PR. Or comments / referenced PRs on the issue you're "trying to fix". Or all the other PRs that have been rejected because they're simply AI-related noise concerning the same issue. Your're welcome to contribute here, but we do need a level of quality and context consideration to reach good solutions. |
|
@acolomb Do we always gotta cry? (Always gotta cry) ("My" PR?) |
Member
Oh, yeah sorry about that mixup. Thanks, Fred! }:-P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow accessing TPDOs and RPDOs using their CiA 301 parameter record indices. Previously only sequential indices (1-512) worked. Extends the fix from PR #613 to also cover RPDO communication records (0x1400-0x15FF) which were missed in that PR.
Fixes #607