Conversation
Adapt tests
new file: custom_components/simple_pid_controller/select.py modified: custom_components/simple_pid_controller/sensor.py
Sync branch with dev
In some cases factors less than 0.01 are useful to make the PID response slower. Reduce the minimum step to 0.001.
Allow specifying gain factors step size 0.001 instead of 0.01
We give out the intended sample time out to simple_pid, which uses it to filter out calls that happen too often. However, we often call simple_pid a fraction of a second sooner than it expects, causing the entire PID loop iteration to be skipped. In my test system this happens on almost every round, causing my 60-second PID controller to effectively only update every 120 seconds. Since we already only call simple_pid every sample_time seconds, there is no need to keep the simple_pid's filtering check in place. The filtering check is the only thing simple_pid uses the sample_time value for, so we can simply omit giving out our sample_time to it.
Fix the PID controller to follow the set sample time (PR#49 replacement)
Rebase add-starting-point
Add starting point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.