Skip to content

modal examples#10

Open
Asharee wants to merge 3 commits into
mainfrom
asharee/modal-dialogs
Open

modal examples#10
Asharee wants to merge 3 commits into
mainfrom
asharee/modal-dialogs

Conversation

@Asharee
Copy link
Copy Markdown
Contributor

@Asharee Asharee commented May 6, 2026

Modal dialog examples!

@Asharee Asharee requested a review from smonette May 6, 2026 22:43
@Asharee Asharee changed the title modal-scroll.html example modal examples May 6, 2026
Copy link
Copy Markdown

@smonette smonette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asharee This is a great start! Couple request though

Comment thread html/modal-scroll.html Outdated
Comment thread html/modal-scroll.html Outdated
Comment thread html/modal-scroll.html
@Asharee Asharee requested a review from smonette May 13, 2026 17:09
Comment thread html/modal-scroll.html
I write about things that are on my mind and fun personal updates.</p><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br>
<br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br>
<br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br>
<br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repeated
s looks a bit messy for an example. (Maybe I'm being too picky)

Could you flow some text and placeholder images instead? Maybe something along the lines of:

"Scroll down to see the modal. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur consectetur ligula convallis sodales accumsan. Integer non mattis augue. Nam elementum arcu imperdiet tortor fringilla, egestas vulputate dui euismod. Vivamus viverra metus at leo vulputate, nec sodales metus finibus. Vivamus in scelerisque velit. Nullam tempor blandit nibh, et blandit risus euismod in. Vivamus magna nibh, pellentesque et sagittis quis, consectetur a nibh. Curabitur varius diam id justo luctus, eu cursus tortor faucibus. Sed suscipit iaculis sodales."

Also, if you need placeholder images: https://placecats.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants