Bug 103866: show bugs blocked by unresolved dependencies#8
Bug 103866: show bugs blocked by unresolved dependencies#8justdave wants to merge 1 commit intobugzilla:mainfrom
Conversation
|
I see "issues":
|
|
@justdave can you rebase this against the unstable branch, and then force push it? |
There's a lot of conflicts in code that I have no clue how it works and don't know what the intended change was to know what to merge. |
|
Looks like something got merged here that wasn't meant to be, the conflicts all have nothing to do with the patch. What branch should be the target for this merge? It's been a couple years since this was posted. Is unstable still appropriate or should it go on main? |
cf25e58 to
803ab2e
Compare
|
OK, I re-created my local branch from unstable, then cherry-picked this patch off the original upstream branch, then force-pushed it back.
Pretty much what I just did. |
Want this re-approved to ensure it's going on the correct target branch
| blocked_somewhere => | ||
| "(CASE WHEN bugs.bug_id IN" | ||
| . " (SELECT blocked FROM dependencies JOIN bugs ON (dependencies.dependson = bugs.bug_id)" | ||
| . " WHERE bug_status IN" | ||
| . " (SELECT value FROM bug_status WHERE is_open = 1) GROUP BY blocked)" | ||
| . " THEN 1" | ||
| . " ELSE 0" | ||
| . " END)", |
There was a problem hiding this comment.
Do we need to worry about the potential performance impact here? (DoS potential etc.)
I don't think we use the |
|
@dylanwh ping |
|
Confirmed with Dylan on Discord that unstable is dead and this should be rebased against main. |
|
Which is going to require repeating the steps from #8 (comment) again... |
803ab2e to
97782ef
Compare
https://bugzilla.mozilla.org/show_bug.cgi?id=103866
Not tested, but the code looks clean and looks like it should do what it says on the tin.
Roping in Kyohei to look because it's search UI (well, buglist UI really - it's just an additional column you can pick to display).