fix(submissions): improve link validation UX, banner display, and error toasts

[Benjtalkshow]

Summary

• Reconcile frontend link types with the backend enum (github, demo, video, document, presentation, other) so options like Document and Presentation are accepted.
• Allow up to 5 other links per submission while keeping fixed types unique. Smart-pick the next type on Add Link, and block duplicate-type changes / a 6th other with clear toasts.
• Add a 500-character cap with a live counter on the optional Introduction field.
• Pass banner through initialData on submission edit so the saved banner displays (logo was already passing through). Add banner to ParticipantSubmission.
• Mock-fill now derives participationType from myTeam, so a team leader using the mock-fill no longer hits the backend "submit as team" rejection.
• Submission error toasts now use title + description with an 8s duration so the backend error is actually readable in the UI.
• Update SubmissionLinksTab icon mapping for the reconciled link types.

Test plan

• Create a new submission with up to 5 Other links plus the fixed types. Should succeed.
• Try changing an existing link to a duplicate fixed type or to a 6th Other. Should toast and block.
• Pick Document or Presentation in the link type dropdown. Backend should accept.
• Type past 500 chars in Introduction. Browser caps, counter shows N / 500.
• Edit an existing submission that has a banner. Banner should display in the form.
• As a team leader, click Fill mock data. Participation type should be TEAM (not INDIVIDUAL).
• Trigger a backend error from the form. Toast should show Submission failed with the backend message visible as the description for 8 seconds.

Summary by CodeRabbit

• New Features

  • Added banner image support for hackathon project submissions
  • Added video, document, and presentation as new link types
  • Introduced 500-character limit for project introduction
  • Added validation to prevent duplicate link types and limit additional links

• Improvements

  • Enhanced error notifications with improved messaging for submission operations
  • Added visual icons for new link types

[vercel]

@Benjtalkshow is attempting to deploy a commit to the Threadflow Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 37b98a53-221d-4840-b499-e3f02b89fb5a

📥 Commits

Reviewing files that changed from the base of the PR and between 3797a08 and 5590bba.

📒 Files selected for processing (5)

• app/(landing)/hackathons/[slug]/submit/page.tsx
• components/hackathons/submissions/SubmissionForm.tsx
• components/organization/cards/ReviewSubmissionModal/SubmissionLinksTab.tsx
• hooks/hackathon/use-submission.ts
• lib/api/hackathons.ts

---

📝 Walkthrough

Walkthrough

This PR extends the hackathon submission system by adding a banner field to the data model, introducing a bounded introduction field, expanding link types (video, document, presentation), implementing validation to enforce per-type uniqueness and "Other" link limits, updating display icons for new link types, and improving error notification formatting with structured toasts.

Changes

Hackathon Submission Form Enhancements

Layer / File(s)	Summary
Data Model: Banner Field lib/api/hackathons.ts, app/(landing)/hackathons/[slug]/submit/page.tsx	ParticipantSubmission interface adds optional banner field; SubmitProjectPage passes existing submission's banner to SubmissionFormContent initial data when editing.
Introduction Field: Schema and UI components/hackathons/submissions/SubmissionForm.tsx	Submission schema adds optional introduction field with 500-character maximum; form input enforces maxLength={500} and displays character counter helper text.
Link Types and Validation Logic components/hackathons/submissions/SubmissionForm.tsx	Link type constants expand to video, document, presentation alongside existing types; handleAddLink and handleLinkChange prevent duplicate fixed-type selections, cap "Other" link count, and show toast errors when limits are reached. Validation messages updated to reference new link-type set (Demo, Video, Document, Presentation, Other).
Link Icon Display: Icon Mapping for Review components/organization/cards/ReviewSubmissionModal/SubmissionLinksTab.tsx	SubmissionLinksTab imports additional icons (Play, Video, FileText, Presentation) and extends getIcon() switch to map new link types to corresponding icons in submission review.
Mock Data: Derive Participation Type components/hackathons/submissions/SubmissionForm.tsx	handleFillMockData derives participationType from whether the user has a team instead of hardcoded value.
Error Handling: Structured Toast Notifications hooks/hackathon/use-submission.ts	Create, update, and remove error handlers emit structured error toasts (title, description, duration: 8000) instead of plain error messages.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• boundlessfi/boundless#443: Modifies conditional link-type validation (requireGithub, requireDemoVideo, requireOtherLinks) in the same form file—directly related to the expanded link-type set and validation enforcement introduced here.
• boundlessfi/boundless#458: Updates SubmitProjectPage to build initial data for SubmissionFormContent (adds teamName/teamMembers)—parallel to this PR's banner field passing.
• boundlessfi/boundless#380: Modifies SubmissionLinksTab icon mapping logic—directly related to the new icon support for expanded link types.

Suggested reviewers

• 0xdevcollins

Poem

🐰 Forms grow richer, types expand with care,
Links now dance as video, doc, and flair,
Banners flutter, limits guard each space,
Toasts bloom structured—errors find their place!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: link validation UX improvements, banner display fixes, and error toast enhancements, all of which are reflected across the modified files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}