Skip to content

Include current error when retry attempts are exhausted#210

Open
himanalot wants to merge 1 commit into
bitcoindevkit:masterfrom
himanalot:fix/all-attempts-errored-errors
Open

Include current error when retry attempts are exhausted#210
himanalot wants to merge 1 commit into
bitcoindevkit:masterfrom
himanalot:fix/all-attempts-errored-errors

Conversation

@himanalot
Copy link
Copy Markdown

Fixes #186.

When an inner call failed, the retry loop checked retries_exhausted before pushing the current error into errors. With retry = 0, this returned AllAttemptsErrored([]) and dropped the underlying failure.

This records the current error before returning the exhausted-attempts error, for both request failures and client recreation failures. It also adds regression coverage for retry = 0 and accumulated retry errors.

Testing:

  • Not run locally (cargo is not installed in this environment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Routinely returns AllAttemptsErrored([]) on failed requests

1 participant