237 add plugins to disabled features

.github/dependabot.yml

@@ -0,0 +1,12 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  # Maintain dependencies for Composer
+  - package-ecosystem: "composer"
+    directory: "/"
+    schedule:
+      interval: "daily"

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: ['7.4', '8.0']
+        php-versions: ['8.1', '8.2', '8.3']
         experimental: [false]
 
     steps:
@@ -30,19 +30,15 @@ jobs:
       run: composer install --dev --no-interaction
     - name: Execute tests without coverage
       run: tools/phpunit --testsuite="BigBlueButton unit test suite,BigBlueButton integration test suite"
-   
+
   PHP:
     name: PHP ${{ matrix.php-versions }}
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        php-versions: ['7.4','8.0']
+        php-versions: ['8.1', '8.2', '8.3']
         experimental: [false]
-        include:
-          - php-versions: '8.1'
-            experimental: true
-
     steps:
     - name: Checkout
       uses: actions/checkout@v2
@@ -65,10 +61,17 @@ jobs:
         tools/phpunit --coverage-clover=build/logs/coverage.xml --testsuite="BigBlueButton unit test suite,BigBlueButton integration test suite"
     - name: Execute tests without coverage
       if: ${{ matrix.experimental }}
-      run: tools/phpunit --testsuite="BigBlueButton test suite"
+      run: tools/phpunit --testsuite="BigBlueButton unit test suite,BigBlueButton integration test suite"
       continue-on-error: true
-    - name: Coveralls
-      env:
-        COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      if: ${{ matrix.php-versions == '7.4' && env.COVERALLS_REPO_TOKEN != null }}
-      run: tools/php-coveralls --coverage_clover=build/logs/coverage.xml -v
+    - name: Upload coverage
+      if: ${{ matrix.php-versions == '8.1' }}
+      uses: codecov/codecov-action@v3
+    - name: Run rector
+      if: ${{ matrix.php-versions == '8.1' }}
+      run: tools/rector process --dry-run
+    - name: Run psalm
+      if: ${{ matrix.php-versions == '8.1' }}
+      run: tools/psalm
+    - name: Run phpstan
+      if: ${{ matrix.php-versions == '8.1' }}
+      run: tools/phpstan

.gitignore

@@ -30,3 +30,5 @@ reports
 #
 # See https://github.com/littleredbutton/bigbluebutton-api-php/pull/115 for the discussion.
 /composer.lock
+
+/Makefile.iservmake

.php-cs-fixer.php

@@ -5,8 +5,8 @@
 $finder = \PhpCsFixer\Finder::create()
     ->files()
     ->name('*.php')
-    ->in(__DIR__ . '/src')
-    ->in(__DIR__ . '/tests');
+    ->in(__DIR__.'/src')
+    ->in(__DIR__.'/tests');
 
 $config = new PhpCsFixer\Config();
 
@@ -18,6 +18,11 @@
         'yoda_style' => false,
         'single_line_throw' => false,
         'increment_style' => false,
+        'modernize_strpos' => false,
+        'get_class_to_class_keyword' => false,
+        'declare_strict_types' => [
+            'strategy' => 'enforce'
+        ]
     ])
     ->setRiskyAllowed(true)
     ->setFinder($finder);

README.md

@@ -1,7 +1,7 @@
 # :tada: Best BigBlueButton API for PHP
 
 The unofficial and easiest to use **BigBlueButton API for PHP**, makes easy for
-developers to use [BigBlueButton API] v2.2+ for **PHP 7.4+**.
+developers to use [BigBlueButton API] v2.2+ for **PHP 8.1+**.
 
 ![Build Status](https://github.com/littleredbutton/bigbluebutton-api-php/workflows/CI/badge.svg)
 [![Coverage Status](https://coveralls.io/repos/github/littleredbutton/bigbluebutton-api-php/badge.svg?branch=master)](https://coveralls.io/github/littleredbutton/bigbluebutton-api-php?branch=master)
@@ -56,15 +56,15 @@ following advantages:
 - Development is simplified through git hooks and contributor guidelines
 - Documentation is up-to-date and complete
 - API is fixed and extended to exploit the full potential
-- Require at least PHP 7.4, which allows to make the code more efficient and
+- Require at least PHP 8.1, which allows to make the code more efficient and
   readable
 
 ## :gear: Installation and usage
 ### Requirements
 In order to use this library you have to make sure to meet the following
 requirements:
 
-- PHP 7.4 or above.
+- PHP 8.1 or above.
 - curl library installed.
 - mbstring library installed.
 - xml library installed.
@@ -89,7 +89,7 @@ $bbb = new BigBlueButton($apiUrl, $apiSecret);
 
 If you didn't use composer before, make sure that you include `vendor/autoload.php`.
 
-In general the usage is closly related to the official [API description](https://docs.bigbluebutton.org/dev/api.html). This means to create a room, you have to create a `CreateMeetingParameters` object and set all required parameters via the related setter method. This means to set the `attendeePW`, you have to call `setAttendeePW` and so on.
+In general the usage is closly related to the official [API description](https://docs.bigbluebutton.org/dev/api.html). This means to create a room, you have to create a `CreateMeetingParameters` object and set all required parameters via the related setter method.
 
 #### Test if API url and secret are valid
 ```php
@@ -126,8 +126,6 @@ $version = $bbb->getApiVersion()->getVersion();
 use BigBlueButton\Parameters\CreateMeetingParameters;
 
 $createMeetingParams = new CreateMeetingParameters($meetingID, $meetingName);
-$createMeetingParams->setAttendeePW($attendee_password);
-$createMeetingParams->setModeratorPW($moderator_password);
 
 $createMeetingResponse = $bbb->createMeeting($createMeetingParams);
 
@@ -155,10 +153,10 @@ $createMeetingParams->setGuestPolicyAlwaysAcceptAuth();
 #### Join a meeting
 ```php
 use BigBlueButton\Parameters\JoinMeetingParameters;
+use BigBlueButton\Enum\Role;
 
-$joinMeetingParams = new JoinMeetingParameters($room->uid, $displayname, $password);
+$joinMeetingParams = new JoinMeetingParameters($room->uid, $displayname, Role::VIEWER);
 $joinMeetingParams->setCreateTime($createMeetingResponse->getCreationTime());
-$joinMeetingParams->setJoinViaHtml5(true);
 $joinMeetingParams->setRedirect(true);
 
 $joinUrl = $bbb->getJoinMeetingURL($joinMeetingParams);
@@ -170,7 +168,7 @@ $joinUrl = $bbb->getJoinMeetingURL($joinMeetingParams);
 ```php
 use BigBlueButton\Parameters\EndMeetingParameters;
 
-$endMeetingParams = new EndMeetingParameters($meetingID, $moderator_password);
+$endMeetingParams = new EndMeetingParameters($meetingID);
 $response = $bbb->endMeeting($endMeetingParams);
 ```
 
@@ -206,7 +204,7 @@ if ($response->success() && $response->isRunning()) {
 ```php
 use BigBlueButton\Parameters\GetMeetingInfoParameters;
 
-$getMeetingInfoParams = new GetMeetingInfoParameters($meetingID, $moderator_password);
+$getMeetingInfoParams = new GetMeetingInfoParameters($meetingID);
 
 $response = $bbb->getMeetingInfo($getMeetingInfoParams);
 
@@ -483,4 +481,3 @@ composer test-integration
 Bugs and feature request are tracked on [GitHub](https://github.com/littleredbutton/bigbluebutton-api-php/issues)
 
 [BigBlueButton API]: https://docs.bigbluebutton.org/dev/api.html
-

composer.json

@@ -58,11 +58,12 @@
     "docs": "https://github.com/littleredbutton/bigbluebutton-api-php/blob/master/README.md"
   },
   "require": {
-    "php": ">=7.4",
+    "php": ">=8.1",
     "ext-curl": "*",
     "ext-simplexml": "*",
     "ext-mbstring": "*",
-    "ext-json": "*"
+    "ext-json": "*",
+    "ext-dom": "*"
   },
   "suggest": {
     "psr/http-client-implementation": "To use the PsrHttpClientTransport.",
@@ -74,11 +75,11 @@
   "require-dev": {
     "psr/http-client": "^1.0",
     "psr/http-factory": "^1.0",
-    "psr/http-message": "^1.0",
-    "symfony/dotenv": "^3.4|^4.0|^5.0",
-    "symfony/http-client-contracts": "^1.1|^2.0",
-    "symfony/http-client": "^4.4|^5.0",
-    "symfony/process": "^3.4|^4.0|^5.0",
+    "psr/http-message": "^1.0 || ^2.0",
+    "symfony/dotenv": "^5.4|^6.4|^7.0",
+    "symfony/http-client-contracts": "^1.1|^2.0|^3.0",
+    "symfony/http-client": "^5.4|^6.4|^7.0",
+    "symfony/process": "^5.4|^6.4|^7.0",
     "nyholm/psr7": "^1.4"
   },
   "autoload": {
@@ -91,8 +92,17 @@
   },
   "autoload-dev": {
     "psr-4": {
+      "BigBlueButton\\Tests\\Common\\": [
+        "tests/common"
+      ],
       "BigBlueButton\\Tests\\Functional\\": [
         "tests/functional"
+      ],
+      "BigBlueButton\\Tests\\Integration\\": [
+        "tests/integration"
+      ],
+      "BigBlueButton\\Tests\\Unit\\": [
+        "tests/unit"
       ]
     }
   },
@@ -102,9 +112,12 @@
     "test-functional": "tools/phpunit --testsuite=\"BigBlueButton functional test suite\" --exclude-group=functional-legacy",
     "cs-fix": "tools/php-cs-fixer fix --allow-risky=yes",
     "cs-test": "tools/php-cs-fixer fix --dry-run --allow-risky=yes",
-    "psalm": "psalm --threads=1",
-    "psalm-clear": "psalm --clear-cache && psalm --clear-global-cache",
-    "psalm-fix": "psalm --alter --issues=InvalidReturnType,InvalidNullableReturnType,MissingParamType,InvalidFalsableReturnType",
+    "psalm": "tools/psalm --threads=1",
+    "psalm-clear": "tools/psalm --clear-cache && tools/psalm --clear-global-cache",
+    "psalm-fix": "tools/psalm --alter --issues=InvalidReturnType,InvalidNullableReturnType,MissingParamType,InvalidFalsableReturnType",
+    "phpstan": "tools/phpstan analyse",
+    "rector": "tools/rector process --dry-run src/ tests/",
+    "rector-fix": "tools/rector process src/ tests/",
     "post-install-cmd": "tools/composer-git-hooks add --ignore-lock",
     "post-update-cmd": "tools/composer-git-hooks update"
   },
@@ -115,7 +128,9 @@
       ],
       "pre-push": [
         "tools/phpunit --testsuite=\"BigBlueButton unit test suite,BigBlueButton integration test suite\"",
-        "tools/psalm --threads=1"
+        "tools/psalm --threads=1",
+        "tools/phpstan analyse",
+        "tools/rector process --dry-run src/ tests/"
       ],
       "post-merge": "composer install",
       "post-checkout": "composer install"
@@ -124,13 +139,14 @@
       "brainmaestro/composer-git-hooks": "^2.8",
       "extensions": {
         "phpunit/phpunit": {
-          "fakerphp/faker": "^1.14"
+          "fakerphp/faker": "1.20.*"
         }
       },
       "friendsofphp/php-cs-fixer": "^3.3",
-      "php-coveralls/php-coveralls": "^2.4",
-      "phpunit/phpunit": "^8",
-      "vimeo/psalm": "^4.22"
+      "phpstan/phpstan": "^1.10",
+      "phpunit/phpunit": "^9",
+      "rector/rector": "^1.0",
+      "vimeo/psalm": "^5.23"
     }
   }
 }

phpstan.neon

@@ -0,0 +1,17 @@
+parameters:
+    paths:
+        - src
+        - tests
+    parallel:
+        maximumNumberOfProcesses: 4
+    level: 6
+    inferPrivatePropertyTypeFromConstructor: true
+    bootstrapFiles:
+      - tools/bootstrap.php
+    ignoreErrors:
+        -
+            message: '#^Offset ''input'' does not exist on array\{\}\.$#'
+            path: tests/integration/Http/Transport/CurlTransportTest.php
+        -
+            message: '#^Offset ''vars'' does not exist on array\{\}\.$#'
+            path: tests/integration/Http/Transport/CurlTransportTest.php

phpunit.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" backupStaticAttributes="false" bootstrap="./tests/bootstrap.php" colors="true" convertDeprecationsToExceptions="false" convertErrorsToExceptions="true" convertNoticesToExceptions="true" convertWarningsToExceptions="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
+  <coverage processUncoveredFiles="true">
+    <include>
+      <directory suffix=".php">./src/</directory>
+    </include>
+  </coverage>
+  <testsuites>
+    <testsuite name="BigBlueButton unit test suite">
+      <directory>./tests/unit/</directory>
+    </testsuite>
+    <testsuite name="BigBlueButton integration test suite">
+      <directory>./tests/integration/</directory>
+    </testsuite>
+    <testsuite name="BigBlueButton functional test suite">
+      <directory>./tests/functional/</directory>
+    </testsuite>
+  </testsuites>
+</phpunit>

rector.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\Assign\RemoveUnusedVariableAssignRector;
+use Rector\DeadCode\Rector\ClassMethod\RemoveUselessParamTagRector;
+use Rector\DeadCode\Rector\ClassMethod\RemoveUselessReturnTagRector;
+use Rector\Privatization\Rector\Class_\FinalizeTestCaseClassRector;
+use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector;
+use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;
+use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector;
+use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictSetUpRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__.'/src',
+        __DIR__.'/tests',
+    ])
+    ->withPhpSets()
+    ->withRules([
+        AddVoidReturnTypeWhereNoReturnRector::class,
+        DeclareStrictTypesRector::class,
+        FinalizeTestCaseClassRector::class,
+        RemoveUnusedVariableAssignRector::class,
+        RemoveUselessParamTagRector::class,
+        RemoveUselessReturnTagRector::class,
+        TypedPropertyFromAssignsRector::class,
+        TypedPropertyFromStrictConstructorRector::class,
+        TypedPropertyFromStrictSetUpRector::class,
+    ])
+    ->withImportNames(importShortClasses: false, removeUnusedImports: true)
+;