fix: default CLIENT to reth in .env and docker-compose.yml#1035
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
The default .env ships CLIENT=geth, which combined with USE_BASE_CONSENSUS=true crash-loops on a clean checkout. This contradicts the README (reth is documented as default) and the Azul migration guide (geth + base-consensus is unsupported). Change the CLIENT fallback from geth to reth so that a clean checkout works out of the box. Fixes #1010
mw2000
force-pushed
the
mihirwadekar/fix-default-env-client-reth
branch
from
8349c6d to
dd9ef9f
Compare
mw2000
changed the title
niran
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default configuration ships
CLIENT=gethin two places:.env—CLIENT=${CLIENT:-geth}sets the env var togethdocker-compose.yml—${CLIENT:-geth}fallback in both service definitionsCombined with
USE_BASE_CONSENSUS=truein.env, this is the one combination that crash-loops on a clean checkout. Any operator who clones the release tag and runsdocker compose upwithout modifications hits an immediate startup error.To fix, we make set
rethas the defaultIncludes cherry-pick of #1011. Fixes #1010.