Improve MCP SVG component with accessibility, theming, and flexible sizing#1355
Open
yasnazariel wants to merge 1 commit intobase:masterfrom
Open
Improve MCP SVG component with accessibility, theming, and flexible sizing#1355yasnazariel wants to merge 1 commit intobase:masterfrom
yasnazariel wants to merge 1 commit intobase:masterfrom
Conversation
…ity) Refactor MCP SVG component to improve usability, accessibility, and flexibility. Changes: - Replace hardcoded fill color with `currentColor` for theme support - Add `size` prop for responsive scaling - Add `className` and SVG props for better reusability - Remove fixed pt units in favor of flexible sizing - Add accessibility attributes (`role`, `aria-label`) This makes the component more reusable across different UI contexts and compatible with dark/light themes.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the MCP SVG component to make it more reusable, accessible, and theme-friendly.
Changes
fill="white"tocurrentColorto support dark/light themessizeprop for flexible and responsive sizingclassNameand spread props for easier customizationptunits in favor of scalable dimensionsrole="img",aria-label)Why this matters
The previous implementation was:
This update ensures the component can be used consistently across the app while following best practices.
Impact
Example