Issue #7083: Icon browser/picker in core#5237
Issue #7083: Icon browser/picker in core#5237docwilmot wants to merge 28 commits intobackdrop:1.xfrom
Conversation
|
Related to: backdrop/backdrop-issues#7083 |
Rename the icon_get_all_details() parameter from $icon_key to $icon_name and update internal variable names.
|
I've committed a temporary change to path |
|
Tugboat has finished building a preview for this pull request! Website: https://pr5237-ina3t5vmb6zn5wpklwgtmcfhs8lwsza2.tugboatqa.com/ This preview will automatically expire on the 20th of June, 2026. |
| ), | ||
| ); | ||
|
|
||
| // jQuery treeTable plugin. |
There was a problem hiding this comment.
Copy-paste, right? 😆
Better remove or fix this misleading comment.
| define('TOKEN_MAX_DEPTH', 9); | ||
|
|
||
| /** | ||
| * The maximum depth for token tree recursion. |
There was a problem hiding this comment.
Another misleading comment (copy-paste apparently). 😉
There was a problem hiding this comment.
Do we have to make the max hardcoded? Or is there a way to let modules (or themes) adapt that?
| 'callback' => 'system_icon_browser_ajax_form_open_dialog', | ||
| ); | ||
|
|
||
| backdrop_add_js(backdrop_get_path('module', 'system') . '/js/icon_browser.js'); |
There was a problem hiding this comment.
Do we need this here, anyway? BTW, why attaching as regular JS, while we have a defined library?
Or is this just for the demo link?
| '#type' => 'textfield', | ||
| '#title' => t('Default file directory'), | ||
| '#description' => t('Subdirectory where files will be stored if the file is uploaded through the file/add page. This field supports tokens.') . ' ' . theme('token_tree_link'), | ||
| '#description' => t('Subdirectory where files will be stored if the file is uploaded through the file/add page. This field supports tokens.') . ' ' . theme('icon_browser_link'), |
There was a problem hiding this comment.
Let's not forget to remove this link, as soon as we're done with manual testing.
It's only here to demo functionality.
4 participants
Fixes backdrop/backdrop-issues#7083