Skip to content

fix: remove lowercase requirement from linter #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhongkechen merged 1 commit into from
May 6, 2026
+0 −7
Merged

fix: remove lowercase requirement from linter #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/scripts/lintcommit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ def validate_subject(subject_line: str) -> str | None:
if subject.endswith("."):
return "subject must not end with a period"

if subject != subject.lower():
return "subject must be lowercase"

return None


Expand Down
4 changes: 0 additions & 4 deletions .github/scripts/tests/test_lintcommit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ def test_subject_uppercase() -> None:
assert validate_subject("feat: Add new feature") == "subject must be lowercase"


def test_subject_uppercase_acronym_rejected() -> None:
assert validate_subject("ci: configure CI/CD") == "subject must be lowercase"


# region validate_message


Expand Down
Loading