feat: add --from-controller flag for self-contained code generation#703
Open
michaelhtm wants to merge 1 commit into
Open
feat: add --from-controller flag for self-contained code generation#703michaelhtm wants to merge 1 commit into
michaelhtm wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
ack-prow
Bot
added
the
do-not-merge/work-in-progress
ack-prow
Bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
michaelhtm
force-pushed
the
feat/generatefromcontrollers
branch
from
e6c8118 to
a93f9d9
Compare
michaelhtm
changed the title
michaelhtm
force-pushed
the
feat/generatefromcontrollers
branch
2 times, most recently
from
c9ace88 to
2a8b9fa
Compare
…rate Replace shell scripts (build-controller.sh, build-controller-release.sh) with a Go-native pipeline that runs from within the controller repo. The `ack-generate controller` command now handles APIs, deepcopy, CRDs, RBAC, formatting, and boilerplate in a single invocation. Templates and boilerplate files are embedded via go:embed, enabling `go install` without a local code-generator checkout.
michaelhtm
force-pushed
the
feat/generatefromcontrollers
branch
from
2a8b9fa to
e028075
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds
ack-generate controller <service> --from-controllerandack-generate release <service> <version> --from-controller, which runthe full generation pipeline from within a controller repo without
needing shell scripts or a local code-generator checkout.
Usage (from a controller repo):
ack-generate controller s3 --from-controller
ack-generate release s3 v1.2.3 --from-controller
The generated Makefile wires these up:
make generate # installs ack-generate, runs controller --from-controller
make release V=v1.2.3 # installs ack-generate, runs release --from-controller
Without --from-controller, both commands behave exactly as before
existing generation via build-controller.sh and build-controller-release.sh
is unaffected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.