Skip to content

feat: modify generated code for lazyBindControllers feature#698

Open
michaelhtm wants to merge 1 commit into
aws-controllers-k8s:mainfrom
michaelhtm:feat/lazybindcontrollers
Open

feat: modify generated code for lazyBindControllers feature#698
michaelhtm wants to merge 1 commit into
aws-controllers-k8s:mainfrom
michaelhtm:feat/lazybindcontrollers

Conversation

@michaelhtm
Copy link
Copy Markdown
Member

@michaelhtm michaelhtm commented May 8, 2026

related to aws-controllers-k8s/runtime#240

Description of changes:
Changing controller templates

  • pass context when calling BindControllerManagers in main.go
  • add a GroupVersionResource method to resourceDescriptor, used to check if a CRD exists

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 8, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2026
@ack-prow ack-prow Bot requested review from a-hilaly and knottnt May 8, 2026 20:16
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow Bot added the approved label May 8, 2026
@michaelhtm michaelhtm marked this pull request as ready for review May 11, 2026 17:11
@ack-prow ack-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2026
@ack-prow ack-prow Bot requested a review from jlbutler May 11, 2026 17:11
@michaelhtm michaelhtm force-pushed the feat/lazybindcontrollers branch from bc8a23b to 465c44d Compare May 11, 2026 17:36
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 11, 2026

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cloudfront-controller-test 465c44d link true /test cloudfront-controller-test
acm-controller-test 465c44d link true /test acm-controller-test
apigatewayv2-controller-test 465c44d link true /test apigatewayv2-controller-test
efs-controller-test 465c44d link true /test efs-controller-test
documentdb-controller-test 465c44d link true /test documentdb-controller-test
iam-controller-test 465c44d link true /test iam-controller-test
s3-controller-test 465c44d link true /test s3-controller-test
dynamodb-controller-test 465c44d link true /test dynamodb-controller-test
ecr-controller-test 465c44d link true /test ecr-controller-test
pipes-controller-test 465c44d link true /test pipes-controller-test
eks-controller-test 465c44d link true /test eks-controller-test
eventbridge-controller-test 465c44d link true /test eventbridge-controller-test
prometheusservice-controller-test 465c44d link true /test prometheusservice-controller-test
ec2-controller-test 465c44d link true /test ec2-controller-test
lambda-controller-test 465c44d link true /test lambda-controller-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant