Skip to content

Fix nested secrets and names conversion#692

Open
visit1985 wants to merge 2 commits into
aws-controllers-k8s:mainfrom
visit1985:fix/nested-secrets-and-names-conversion
Open

Fix nested secrets and names conversion#692
visit1985 wants to merge 2 commits into
aws-controllers-k8s:mainfrom
visit1985:fix/nested-secrets-and-names-conversion

Conversation

@visit1985
Copy link
Copy Markdown

Issue #, if available:

This PR is related to aws-controllers-k8s/community#2813.

During my attempt to generate the ack-dms-controller, I identified the following problems:

  • Nested secret fields with acronyms (e.g., SASLPassword, SSLClientKeyPassword) could not be found in MemberFields map because the lookup used raw AWS SDK names (SaslPassword, SslClientKeyPassword) while the map is keyed by normalized camelCase names.
  • Secret field setters for nested struct members were not being automatically suppressed based on the is_secret: true configuration.

Description of changes:

  • All secret fields (top-level and nested) marked with is_secret: true automatically suppress SDK→CRD output setters.
  • Field config lookups are now consistently case-insensitive across all code paths.
  • Acronym normalization (e.g., SaslSASL) no longer causes member field lookup failures.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow Bot requested review from a-hilaly and jlbutler April 17, 2026 08:22
@ack-prow ack-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 17, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Apr 17, 2026

Hi @visit1985. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@visit1985 visit1985 changed the title Fix/nested secrets and names conversion Fix nested secrets and names conversion Apr 17, 2026
@michaelhtm
Copy link
Copy Markdown
Member

Thanks @visit1985
/test all

@michaelhtm
Copy link
Copy Markdown
Member

/ok-to-test
/lgtm

@ack-prow ack-prow Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 19, 2026
@ack-prow ack-prow Bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, visit1985

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow Bot added the approved label May 19, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 19, 2026

@visit1985: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-controller-test 28f2111 link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants