fix: sort map keys in renameExportable for deterministic codegen#666
fix: sort map keys in renameExportable for deterministic codegen#666michaelhtm wants to merge 1 commit into
Conversation
|
/close |
|
@michaelhtm: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@michaelhtm: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
michaelhtm
force-pushed
the
fix/flakycapitalization
branch
from
42b7d00 to
0752b22
Compare
|
/LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gustavodiaz7722, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Mutating maps during range causes non-deterministic re-visits of renamed keys, overwriting OriginalMemberName. Sort before iterating.
michaelhtm
force-pushed
the
fix/flakycapitalization
branch
from
4aefadc to
1510527
Compare
|
/retest |
1 similar comment
|
/retest |
michaelhtm
changed the title
2 participants
Description of changes:
Mutating maps during range causes non-deterministic re-visits of
renamed keys, overwriting OriginalMemberName. Sort before iterating.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.