replace conditional synced condition with ready condition in printcolumn#646
Open
michaelhtm wants to merge 1 commit into
Open
replace conditional synced condition with ready condition in printcolumn#646michaelhtm wants to merge 1 commit into
michaelhtm wants to merge 1 commit into
Conversation
Member
Author
|
/test s3-controller-test |
a-hilaly
reviewed
Dec 2, 2025
| {{- if .CRD.PrintSyncedColumn }} | ||
| // +kubebuilder:printcolumn:name="Synced",type="string",priority=0,JSONPath=".status.conditions[?(@.type==\"ACK.ResourceSynced\")].status" | ||
| {{- end }} | ||
| // +kubebuilder:printcolumn:name="Ready",type="string",priority=0,JSONPath=".status.conditions[?(@.type==\"Ready\")].status" |
Member
There was a problem hiding this comment.
Maybe we need to still wrap it with {{- if .CRD.PrintSyncedColumn }} ?
Member
Author
There was a problem hiding this comment.
Is there a reason why we had that?
I would think we want to print the Synced/Ready conditions all the time
Member
There was a problem hiding this comment.
fair. let's remove PrintSyncedColumn ?
michaelhtm
force-pushed
the
addreadyconditionbydefault
branch
from
01755dc to
9bcb3db
Compare
a-hilaly
approved these changes
Dec 2, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2204
Description of changes:
This change adds removes the conditional check that adds the Synced condition,
and replaces it with a default Ready condition.
Ready condition represents that the resource is ready to be consumed by whatever it
depends on
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.