fix: Resolve multiple customer-blocking bugs (#126, #131, #132)#134
Open
PeterNigh wants to merge 3 commits intoaws-cloudformation:masterfrom
Open
fix: Resolve multiple customer-blocking bugs (#126, #131, #132)#134PeterNigh wants to merge 3 commits intoaws-cloudformation:masterfrom
PeterNigh wants to merge 3 commits intoaws-cloudformation:masterfrom
Conversation
PeterNigh
force-pushed
the
fix/multiple-customer-blocking-bugs
branch
6 times, most recently
from
e004a01 to
576f86c
Compare
PeterNigh
force-pushed
the
fix/multiple-customer-blocking-bugs
branch
4 times, most recently
from
ba933a6 to
8e9658b
Compare
…ws-cloudformation#131, aws-cloudformation#132) Fix class-transformer version mismatch (0.3.1 -> 0.5.1) causing silent deserialization failures in generated projects. Remove @ts-ignore from Integer interface so consumers with skipLibCheck:false can compile. Fix timezone-dependent test failure in log-delivery tests. Closes aws-cloudformation#126, aws-cloudformation#132
Replace macos-12 (removed by GitHub) with macos-13. Drop EOL Python 3.8/3.9, add 3.12. Bump python_requires from >=3.8 to >=3.10. Bump all GitHub Actions to v4. Fix upload-artifact unique name requirement. Fix pre-commit eslint hook: replace mirrors-eslint with local hook using project node_modules to prevent version drift. Bump flake8 5.0.4 -> 7.1.2 and bandit 1.7.1 -> 1.8.3 for Python 3.12 compat. Add PyPI release workflow for automated plugin publishing (requires PYPI_API_KEY_CLOUDFORMATION_CLI_TYPESCRIPT_PLUGIN secret). Add pyproject.toml for PEP 517 build system declaration. Closes aws-cloudformation#131
PeterNigh
force-pushed
the
fix/multiple-customer-blocking-bugs
branch
from
8e9658b to
5fe6bbd
Compare
PeterNigh
force-pushed
the
fix/multiple-customer-blocking-bugs
branch
from
c8e4ddc to
616ef05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh pr edit 134 --repo aws-cloudformation/cloudformation-cli-typescript-plugin --body 'Fixes three long-standing GitHub issues blocking customers, plus CI modernization.
Bug fixes (GitHub issues #126, #131, #132):
extends BigIntwith standalone interfaces and explicit type casts.toISOString()instead of raw Date objectsCI/CD modernization:
PYPI_API_KEY_CLOUDFORMATION_CLI_TYPESCRIPT_PLUGINsecret)macos-12(removed by GitHub) withmacos-13python_requiresfrom>=3.8to>=3.10to match CI test matrixmirrors-eslintwith local hook using projectnode_modulespyproject.tomlfor PEP 517 build system declarationPost-merge actions needed:
PYPI_API_KEY_CLOUDFORMATION_CLI_TYPESCRIPT_PLUGINGitHub secretclass-transformerfrom0.3.1to0.5.1in your projectpackage.jsonAll 125 TypeScript tests pass in CI. Clean compile with
skipLibCheck: false.Closes #126, #131, #132'