Some fixes#17
Merged
Merged
Conversation
Contributor
Author
|
@averne can we upstream please? |
Owner
|
Hello, I'd like to take a proper look at this code before merging, but unfortunately I've been kept extremely with worl lately. |
Contributor
Author
|
No pressure, was just making sure this didn't dodge your inbox. |
Owner
|
Thanks for the PR |
Contributor
Author
|
@averne could you please cut a release on GItHub/HomeBrew AppStore? |
Owner
|
Yes, I'll do it over the weekend |
Owner
|
@ViRb3 I don't have the ability to test on hardware right now, would you be able to confirm whether this build works? After which I'll tag a release. Thanks in advance. |
Contributor
Author
|
@averne can confirm movies over HTTPS work, and so do external subtitles over HTTPS. |
Owner
|
Thanks, just pushed a release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mpv not honoring system proxy
I needed to use this for a specific Android WiFi hotspot use case, and realized that while listing was fine, playing videos failed with error -13. After this fix, videos can be played fine.
Fix external subtitles over HTTP
I thought I tested this when developing the HTTP support, but seems like somehow I missed it. Confirmed working after this fix.
Fix race condition in gimp
Appears to be sporadic and only affects GIMP2. Doesn't harm GIMP3 though, so left for both cases.
Please review per commit, I isolated the changes cleanly. Also please don't squash for the same reason.