fix(connection): reject connector_type values that violate platform slug pattern (BLDX-1294)

[Aryamanz29]

Summary

Connection.creator and Connection.creator_async (both pyatlan and pyatlan_v9) now validate connector_type.value against ^[a-z0-9-]+$ — the same pattern the Atlan platform's server-side asset-import (RAB) path enforces. Mirrors the existing Java SDK constraint.

Linear: BLDX-1294
Origin: APP-2263 — customer created dev_cmdr connection via pyatlan, RAB then rejected every asset-import referencing it, leaving phantom Connection rows in Atlas.

Why

Today, pyatlan accepts any string a customer passes to AtlanConnectorType.CREATE_CUSTOM(value=...). The slug ends up embedded in connectionQualifiedName (default/{slug}/{epoch}). Later, when assets are imported under that connection, the server-side RAB validator rejects the QN because the slug doesn't match ^[a-z0-9-]+$. Symptoms reported:

1. Customer creates dev_cmdr via pyatlan → succeeds.
2. Customer runs RAB / asset-import → fails with regex rejection.
3. Phantom Connection row remains in Atlas; customer has to manually clean up.

The Java SDK was tightened to enforce the same regex at creation time. pyatlan was left behind.

What changes

• pyatlan/model/assets/connection.py — new module-level _CONNECTOR_TYPE_VALUE_PATTERN + _validate_connector_type_value() helper. Both Connection.creator and Connection.creator_async now call it right after validate_required_fields.
• pyatlan_v9/model/assets/connection.py — imports the same helper from pyatlan (single source of truth) and calls it in both creator paths.
• pyatlan_v9/model/assets/_overlays/connection.py — overlay updated so the next codegen regen preserves the fix.

Built-in AtlanConnectorType members (SNOWFLAKE, MYSQL, AMAZON_MSK, …) are all kebab-case and pass the check unchanged. The validator only bites custom types created via CREATE_CUSTOM(value=...) — exactly the surface the customer hit.

Test plan

pyatlan (tests/unit/model/connection_test.py)

• 6 bad-value parametrized cases: dev_cmdr, dev.cmdr, dev cmdr, dev/cmdr, dev@cmdr, dev_ — each must raise ValueError("Invalid connector_type value ...")
• 6 good-value regression pins: dev-cmdr, snowflake, amazon-msk, a, abc123, 123-abc-456 — all must construct successfully
• test_creator_accepts_builtin_connector_types — built-in SNOWFLAKE continues to work (regression guard)
• test_creator_async_rejects_invalid_connector_type_value — async path enforces the same rule

pyatlan_v9 (tests_v9/unit/model/connection_test.py)

• Parametrized bad-values (mirrors pyatlan)
• Valid hyphen-slug accepted

Regression

• 1909 tests pass across tests/unit/model/ + tests_v9/unit/model/.
• Pre-commit green (ruff, ruff-format).

Notes

• AtlanConnectorType.CREATE_CUSTOM already lowercases input, so the validator never sees Dev-CMDR — it's seen as dev-cmdr (valid). The validator catches what survives lowercasing: underscores, dots, special chars, whitespace.
• The validator is intentionally not called from CREATE_CUSTOM itself. CREATE_CUSTOM is also used internally by _get_connector_type_from_qualified_name to parse existing QNs — validating there would break the ability to read connections that already have non-conforming slugs in Atlas (pre-existing state should remain readable; only new creations are tightened).

🤖 Generated with Claude Code