Skip to content

fix: add parameterized queries in sqlite-vec-ivf.c #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add parameterized queries in sqlite-vec-ivf.c #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions sqlite-vec-ivf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,14 +353,10 @@ static int ivf_cell_find_or_create(vec0_vtab *p, int col_idx, i64 centroid_id,
" WHERE centroid_id = ? AND n_vectors < %d LIMIT 1",
p->schemaName, p->tableName, col_idx, VEC0_IVF_CELL_MAX_VECTORS);
if (!zSql) return SQLITE_NOMEM;
// Cache this manually
if (!p->stmtIvfCellMeta[col_idx]) {
rc = sqlite3_prepare_v2(p->db, zSql, -1, &p->stmtIvfCellMeta[col_idx], NULL);
sqlite3_free(zSql);
if (rc != SQLITE_OK) return rc;
} else {
sqlite3_free(zSql);
}
// Cache this manually (stmt was reset to NULL above)
rc = sqlite3_prepare_v2(p->db, zSql, -1, &p->stmtIvfCellMeta[col_idx], NULL);
sqlite3_free(zSql);
if (rc != SQLITE_OK) return rc;

sqlite3_stmt *stmt = p->stmtIvfCellMeta[col_idx];
sqlite3_reset(stmt);
Expand Down