Fix usage of RestAPI::trigger#99
Open
ericonr wants to merge 1 commit intoareaDetector:masterfrom
Open
Conversation
This method expects its second parameter, 'exposure', to be 0 when using internal series, since in that case it's not necessary to send an updated acquireTime parameter. When in internal series mode, the Simplon API correctly waits for the acquisition to be complete to return, and the additional waiting implemented in RestAPI::trigger isn't necessary. The conditional here checks for TRIGGER_MODE_INTE because TRIGGER_MODE_INTS and TRIGGER_MODE_CONTINUOUS both map to internal series trigger and don't suffer from this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method expects its second parameter, 'exposure', to be 0 when using internal series, since in that case it's not necessary to send an updated acquireTime parameter. When in internal series mode, the Simplon API correctly waits for the acquisition to be complete to return, and the additional waiting implemented in RestAPI::trigger isn't necessary.
The conditional here checks for TRIGGER_MODE_INTE because TRIGGER_MODE_INTS and TRIGGER_MODE_CONTINUOUS both map to internal series trigger and don't suffer from this issue.
RestAPI::triggerhas two ways it can be called, for Internal Series and Enable:ADEiger/eigerApp/src/restApi.cpp
Lines 333 to 342 in 84b9392