Add FWClear for all detectors#98
Open
ericonr wants to merge 2 commits intoareaDetector:masterfrom
Open
Conversation
It's not clear why it was made exclusive to Eiger1, since the command is available and working in all API versions.
It's more adequate for a command. The labels for ZNAM and ONAM are the same, since processing this record always causes the command to run.
Member
|
@ericonr if your tests show that FWClear works with Eiger2 then I will add it to the OPI files for Eiger2. |
Member
Author
|
Using this with Pilatus4 causes a 404 error, because the driver always sends So part of the implementation still has to be specific to the API version... As far as I can see, If I turned How do you suggest I implement this functionality? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94
Pending testing as well, I hope to try it out on Monday.
I wasn't able to edit the widget, would welcome aid there. I'm not at all used to ADL.