fix: remove global SPIClass typedef from HardwareSPI API#269
Open
Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Open
fix: remove global SPIClass typedef from HardwareSPI API#269Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Conversation
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the global
SPIClasstypedef alias fromHardwareSPI.h.Why
HardwareSPIis already the SPI type exposed by ArduinoCore-API.Some cores, such as STM32, already define their own
SPIClasstype or naming conventions at core level. Providing a globalSPIClassalias in the shared API can therefore:Removing the alias keeps the generic API explicit and lets each core decide how its concrete SPI class should be named.
Compatibility
This change may affect code that depends on
SPIClassbeing provided directly by ArduinoCore-API.Cores and libraries using
HardwareSPIdirectly are unaffected.