fix: update pulseIn signatures to use pin_size_t#267
Open
Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Open
fix: update pulseIn signatures to use pin_size_t#267Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Conversation
- Change pulseIn and pulseInLong prototypes from uint8_t pin to pin_size_t pin. Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
pulseIn()andpulseInLong()to usepin_size_tinstead ofuint8_tfor the pin argument.Why
Other GPIO-related APIs already use
pin_size_tto represent pin identifiers. Using the same type here improves API consistency and avoids unnecessary narrowing on targets where pin numbers are not limited to 8 bits.Compatibility
This is backward-compatible for existing boards using small pin numbers, while improving correctness and portability for cores with larger pin ranges (ex : uint32_t) .