feat: deprecate boolean typedef in favor of bool#265
feat: deprecate boolean typedef in favor of bool#265Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Conversation
Ref: arduino#242 Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 16 16
Lines 1076 1076
=======================================
Hits 1028 1028
Misses 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
per1234
left a comment
There was a problem hiding this comment.
Thanks for your pull requests @Aymane-ST! I will close this as a duplicate of the prior #242.
It is true that this PR is slightly higher quality in that it does not contain the out of scope trailing whitespace trimming present in #242. However, those changes are minimal, and beneficial in their own right, and no maintainer requested their removal. So I don't think the presence of those out of scope changes justifies superseding #242 with this PR.
Summary
Deprecate the legacy
booleantypedef in favor of standard C++bool, while keeping it available for backward compatibility.Why
booleanis a historical Arduino alias. In modern C++,boolis the standard and preferred type.Marking
booleanas deprecated:Compatibility
This is a non-breaking change:
booleanremains available,bool,boolean.Ref: #242