feat: extend PinMode enum with INPUT_FLOATING and INPUT_ANALOG#264
Open
Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Open
feat: extend PinMode enum with INPUT_FLOATING and INPUT_ANALOG#264Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Aymane-ST wants to merge 1 commit intoarduino:masterfrom
Conversation
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend
PinModewith:INPUT_FLOATING = INPUTINPUT_ANALOG = 0x5Also add:
OUTPUT_OPEN_DRAIN = OUTPUT_OPENDRAINWhy
Some cores, especially STM32, expose more explicit GPIO modes than the current common API:
INPUT_FLOATINGimproves readability and compatibility with existing code, while remaining an alias ofINPUTINPUT_ANALOGexposes a real hardware mode available on many MCUsOUTPUT_OPEN_DRAINprovides a clearer alias for the existing spellingCompatibility
This is backward-compatible:
INPUT_ANALOGis additive and only affects code that explicitly uses itBenefit
This makes the generic API more expressive and reduces the need for core-specific pin mode constants in sketches and libraries.