feat: expose S3 custom endpoint for fallback CP by jarvis9443 · Pull Request #288 · api7/api7-helm-chart

jarvis9443 · 2026-05-16T01:20:13Z

The Fallback CP feature already supports connecting to S3-compatible storage (MinIO, Ceph, Aliyun OSS, etc.) in both the gateway and dashboard code. However, the endpoint/custom_endpoint fields were missing from the helm charts' values.yaml, making them undiscoverable for users.

This PR exposes the endpoint configuration in both charts:

Gateway chart (charts/gateway):

Add endpoint field to deployment.fallback_cp.aws_s3 comments
Bump version: 0.2.66 → 0.2.67

API7 chart (charts/api7):

Add custom_endpoint field to fallback_cp.aws_s3 comments
Bump version: 0.18.0 → 0.18.1

Note: the field name differs between components — gateway uses endpoint (matching lua-resty-aws-s3 FFI signature) while dashboard uses custom_endpoint (Go mapstructure tag in s3_store.go). Both map to AWS SDK v2's BaseEndpoint.

Summary by CodeRabbit

New Features
- Added optional S3-compatible endpoint configuration for the fallback control plane.
- Documented optional S3-compatible endpoint for the dashboard configuration (commented).
Chores
- Bumped chart versions: gateway to 0.2.67 and api7 to 0.18.1.
Documentation
- Updated chart README badge to reflect new api7 version.

Add the endpoint field to the aws_s3 configuration comments in values.yaml, allowing users to specify an S3-compatible endpoint (MinIO, Ceph, Aliyun OSS, etc.) for the Fallback CP feature. The gateway code already supports this field via the lua-resty-aws-s3 library (AWS SDK v2 BaseEndpoint), it was just not documented in the helm chart. Bump chart version: 0.2.66 -> 0.2.67

coderabbitai · 2026-05-16T01:20:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 95d652eb-9149-45a7-9807-0f612897c202

📥 Commits

Reviewing files that changed from the base of the PR and between 8c06fd8 and 276b8a8.

📒 Files selected for processing (3)

charts/api7/Chart.yaml
charts/api7/README.md
charts/api7/values.yaml

✅ Files skipped from review due to trivial changes (3)

charts/api7/Chart.yaml
charts/api7/README.md
charts/api7/values.yaml

📝 Walkthrough

Walkthrough

Bump Helm chart versions for gateway and api7, and add commented optional S3-compatible endpoint settings in both charts' values files and the api7 README badge.

Changes

Gateway Helm Chart Update

Layer / File(s)	Summary
Gateway chart version and S3 endpoint configuration `charts/gateway/Chart.yaml`, `charts/gateway/values.yaml`	`charts/gateway/Chart.yaml` version -> `0.2.67`. Added commented `deployment.fallback_cp.aws_s3.endpoint` value (empty by default).

api7 Helm Chart Update

Layer / File(s)	Summary
api7 chart version, README badge, and commented values docs `charts/api7/Chart.yaml`, `charts/api7/README.md`, `charts/api7/values.yaml`	`charts/api7/Chart.yaml` version -> `0.18.1`. Updated README version badge. Added commented `custom_endpoint` lines for S3-compatible dashboard storage in `values.yaml` (empty by default).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

api7/api7-helm-chart#276: Also updates Helm chart versions for charts/gateway/Chart.yaml and charts/api7/Chart.yaml.
api7/api7-helm-chart#263: Modifies Helm chart version metadata for charts/api7/Chart.yaml and charts/gateway/Chart.yaml.
api7/api7-helm-chart#274: Related changes to chart version fields and badges for api7 and gateway charts.

Suggested reviewers

nic-6443
AlinsRan

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: exposing an S3 custom endpoint configuration for the gateway's fallback control plane, which is the primary objective of this PR.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
E2e Test Quality Review	✅ Passed	This Helm chart repository contains only YAML configuration. The PR adds S3 endpoint fields to Helm values. No executable code or test suites exist, so E2E testing review is inapplicable.
Security Check	✅ Passed	No security vulnerabilities found. Changes are commented configuration documentation in Helm charts. S3 endpoint fields are empty URL placeholders. Credentials remain in commented examples only.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/expose-s3-endpoint

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Adds the endpoint field to the documented aws_s3 config in the gateway chart's values.yaml, enabling users to discover S3-compatible endpoint support (MinIO, Ceph, Aliyun OSS) for the Fallback CP feature, and bumps the chart version accordingly.

Changes:

Document an optional endpoint field under deployment.fallback_cp.aws_s3 in values.yaml comments.
Bump chart version from 0.2.66 to 0.2.67.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
charts/gateway/values.yaml	Adds commented `endpoint` field to aws_s3 fallback CP configuration
charts/gateway/Chart.yaml	Bumps chart version 0.2.66 → 0.2.67

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add the custom_endpoint field to the aws_s3 configuration comments in the api7 chart values.yaml. The dashboard code already supports this field (mapstructure:"custom_endpoint" in s3_store.go). Note: the gateway chart uses 'endpoint' while the dashboard uses 'custom_endpoint' — these are separate config paths read by different components. Bump api7 chart version: 0.18.0 -> 0.18.1

Copilot AI review requested due to automatic review settings May 16, 2026 01:20

Copilot started reviewing on behalf of jarvis9443 May 16, 2026 01:20 View session

Copilot AI reviewed May 16, 2026

View reviewed changes

jarvis9443 changed the title ~~feat(gateway): expose S3 custom endpoint for fallback CP~~ feat: expose S3 custom endpoint for fallback CP May 16, 2026

nic-6443 approved these changes May 16, 2026

View reviewed changes

nic-6443 merged commit 7c82de9 into main May 16, 2026
3 checks passed

nic-6443 deleted the feat/expose-s3-endpoint branch May 16, 2026 01:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: expose S3 custom endpoint for fallback CP#288

feat: expose S3 custom endpoint for fallback CP#288
nic-6443 merged 2 commits into
mainfrom
feat/expose-s3-endpoint

jarvis9443 commented May 16, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 16, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jarvis9443 commented May 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jarvis9443 commented May 16, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 16, 2026 •

edited

Loading