fix for TIKA-3003 contributed by cesarsotovalero#299
Open
cesarsotovalero wants to merge 1 commit intoapache:masterfrom
cesarsotovalero:TIKA-3003
Open
fix for TIKA-3003 contributed by cesarsotovalero#299cesarsotovalero wants to merge 1 commit intoapache:masterfrom cesarsotovalero:TIKA-3003
cesarsotovalero wants to merge 1 commit intoapache:masterfrom
cesarsotovalero:TIKA-3003
Conversation
|
Looks good to me, who hits the button? Oh. I guess you have conflicts to resolve first. |
Contributor
|
If you want to fix the conflicts, that'd be great...or, this is small enough, I can take it. Let me know. Thank you! |
Contributor
|
As a side note, we've locked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm making this pull reques because the dependency
net.sf.ehcache:ehcache-core, induced transitively fromedu.ucar:cdm:4.5.5, is not used and can be excluded safely. Notice that the size of thejarofehcache-coreis around 1.3MB, thus removing it has a positive impact on the size of moduletika-parsers.