fix TIKA-2623: "get embedded resources in PDF/doc files" (by OhadR)#233
Open
OhadR wants to merge 2 commits intoapache:masterfrom
Open
fix TIKA-2623: "get embedded resources in PDF/doc files" (by OhadR)#233OhadR wants to merge 2 commits intoapache:masterfrom
OhadR wants to merge 2 commits intoapache:masterfrom
Conversation
added 2 commits
April 3, 2018 03:56
…io and apache-poi that tika-parser already use (tika-core needs to change its pom.xml if we want to place it in core)
OhadR
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation: support embedded files in PDF, Word's doc/docx, etc.
i have refactored
FileEmbeddedDocumentExtractor: moved it from tika-cli to tika-parsers, so applications that are dependent on tika-parser, but not on tika-app, can use it.maybe tika-core could be a better place to put this file (like 'ParsingEnbeddedDocumentExtractor'), but then the pom.xml needs to be changed: need to add dependencies of apache-common-io, poi, etc. and we do not wanna do that, because we do not want to add dependencies to tika-core.