fix(bindings/python): track writer position for file tell#7477
Open
zhengkezhou1 wants to merge 1 commit intoapache:mainfrom
Open
fix(bindings/python): track writer position for file tell#7477zhengkezhou1 wants to merge 1 commit intoapache:mainfrom
zhengkezhou1 wants to merge 1 commit intoapache:mainfrom
Conversation
dosubot
Bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6373
Rationale for this change
opendal.Fileopened in write mode currently supports sequential writes, but callingtell()on it fails because writer state does not track the current output position.This change makes write-only files report their current sequential write position without adding seek support or changing the underlying object storage write semantics.
What changes are included in this PR?
Filewriters.tell()starts at0and advances after writes.Are there any user-facing changes?
Yes. Python
opendal.Fileandopendal.AsyncFileopened withmode="wb"now supporttell()for reporting the current sequential write position.AI Usage Statement
This PR was developed with assistance from OpenAI ChatGPT5.5/Codex.