Filter transitive repositories with uninterpolated IDs#12050
Open
gnodet wants to merge 1 commit into
Open
Conversation
The existing filter in mergeRepositories already excluded transitive
repositories with uninterpolated URLs but did not check repository IDs.
When a transitive dependency POM contained an expression like
${eclipseP2RepoId} as a repository ID with a valid URL, it passed the
filter and later caused MavenValidator to throw IllegalArgumentException.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mergeRepositoriesto also exclude repositories whose ID contains uninterpolated expressions (${...}), not just URLsFixes #12049
Context
The existing filter (added in #11357) already excluded transitive repositories with uninterpolated URLs. However, when a transitive dependency POM contained an expression like
${eclipseP2RepoId}as a repository ID with a valid URL, it passed the filter and later causedMavenValidator.validateRemoteRepositoryto throwIllegalArgumentException, failing the build.The consuming project has no control over third-party POM content, so these invalid repositories should be silently skipped (they can't be useful in the consuming project's context anyway).
Test plan
testMergeRepositoriesto verify repositories with uninterpolated IDs are filteredClaude Code on behalf of Guillaume Nodet