Fix #12045: warn when effective model analysis fails for inherited plugins#12046
Merged
Conversation
…ugins Change the log level from debug to warning when effective model analysis fails in PluginUpgradeStrategy, so users are aware when plugins inherited from remote parent POMs cannot be detected for upgrade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Register transporter factories via @provides methods so they properly feed into the DI Map<String, TransporterFactory>, fixing the standalone session's ability to resolve remote parent POMs from Maven Central. The previous approach of binding TransporterProvider directly was overridden by the @provides method in RepositorySystemSupplier which received an empty factory map, leaving no HTTP transport available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that the standalone session can resolve org.apache:apache:23 from Maven Central and detect maven-enforcer-plugin:1.4.1 in the parent's pluginManagement as needing a Maven 4 compatibility upgrade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rmannibucau
approved these changes
May 14, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debugtowarningwhen effective model analysis fails inPluginUpgradeStrategy, so users are informed when plugins inherited from remote parent POMs cannot be detected for upgrade@Providesmethods so they properly feed into the DIMap<String, TransporterFactory>. The previous approach of bindingTransporterProviderdirectly was overridden by the@Providesmethod inRepositorySystemSupplierwhich received an empty factory map, leaving no HTTP transport availableBefore
mvnup applyon accumulo-wikisearch silently reports "No plugin upgrades needed" for all 4 POMs, despite inheritingmaven-enforcer-plugin:1.4.1fromorg.apache:apache:23.After
mvnup applycorrectly detects and addspluginManagemententries for 3 inherited plugins that need Maven 4 compatibility upgrades:maven-enforcer-plugin→3.0.0maven-remote-resources-plugin→3.0.0maven-shade-plugin→3.5.0Closes #12045
Test plan
PluginUpgradeStrategyTesttests pass (20 tests)Claude Code on behalf of Guillaume Nodet