Skip to content

[2.x] Undo GAV changes #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cstamas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[2.x] Undo GAV changes #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions maven-batch-executor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven-executor</artifactId>
<groupId>org.apache.maven.executor</groupId>
<artifactId>executor</artifactId>
<version>2.0.0-SNAPSHOT</version>
</parent>

<groupId>org.apache.maven.executor</groupId>
<artifactId>maven-batch-executor</artifactId>
<packaging>jar</packaging>

Expand Down
4 changes: 2 additions & 2 deletions maven-executor-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven-executor</artifactId>
<groupId>org.apache.maven.executor</groupId>
<artifactId>executor</artifactId>
<version>2.0.0-SNAPSHOT</version>
</parent>

Expand Down
5 changes: 2 additions & 3 deletions maven-executor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven-executor</artifactId>
<groupId>org.apache.maven.executor</groupId>
<artifactId>executor</artifactId>
<version>2.0.0-SNAPSHOT</version>
</parent>

<groupId>org.apache.maven.executor</groupId>
<artifactId>maven-executor</artifactId>
<packaging>jar</packaging>

Expand Down
14 changes: 8 additions & 6 deletions maven-executor/src/main/java/org/apache/maven/executor/support/ExecutorHelperImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,14 @@ public String mavenVersion() {
if (closed.get()) {
throw new ExecutorException("Executor is closed");
}
return cache.computeIfAbsent("maven.version", k -> getExecutor(
Mode.AUTO,
ExecutorRequest.mavenBuilder()
.userHomeDirectory(ExecutorRequest.discoverUserHomeDirectory())
.build())
.mavenVersion());
return cache.computeIfAbsent(
"maven.version",
k -> getExecutor(
Mode.AUTO,
ExecutorRequest.mavenBuilder()
.userHomeDirectory(ExecutorRequest.discoverUserHomeDirectory())
.build())
.mavenVersion());
Copy link
Copy Markdown
Member

@hboutemy hboutemy May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is that change related to "undo GAV change"?

}

@Override
Expand Down
7 changes: 4 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@
<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven-parent</artifactId>
<version>47</version>
<version>48</version>
Copy link
Copy Markdown
Member

@hboutemy hboutemy May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to "Undo GAV change"

<relativePath />
</parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven-executor</artifactId>

<groupId>org.apache.maven.executor</groupId>
<artifactId>executor</artifactId>
<version>2.0.0-SNAPSHOT</version>
<packaging>pom</packaging>

Expand Down
4 changes: 2 additions & 2 deletions providers/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven-executor</artifactId>
<groupId>org.apache.maven.executor</groupId>
<artifactId>executor</artifactId>
<version>2.0.0-SNAPSHOT</version>
</parent>

Expand Down
5 changes: 2 additions & 3 deletions test-utilities/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven-executor</artifactId>
<groupId>org.apache.maven.executor</groupId>
<artifactId>executor</artifactId>
<version>2.0.0-SNAPSHOT</version>
</parent>

<groupId>org.apache.maven.executor</groupId>
<artifactId>test-utilities</artifactId>
<packaging>jar</packaging>

Expand Down
Loading