HIVE-27382: Migrate postgres-tpcds-metastore image to the Git repo#6490
Open
zabetak wants to merge 1 commit into
Open
HIVE-27382: Migrate postgres-tpcds-metastore image to the Git repo#6490zabetak wants to merge 1 commit into
zabetak wants to merge 1 commit into
Conversation
1. Move necessary files from https://github.com/zabetak/hive-postgres-metastore repo to ASF. 2. Remove redundant information and update README file. 3. Create GitHub action for publishing new image to ASF Dockerhub on-demand.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+34
to
+57
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 1 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd | ||
|
|
||
| - name: Login to Docker Hub | ||
| if: ${{ github.event.inputs.pushImage == 'true' }} | ||
| uses: docker/login-action@b45d80f862d83dbcd57f89517bcf500b2ab88fb2 | ||
| with: | ||
| username: ${{ secrets.DOCKERHUB_USER }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
|
|
||
| - name: Build and optionally push Docker image | ||
| uses: docker/build-push-action@d08e5c354a6adb9ed34480a06d141179aa583294 | ||
| with: | ||
| context: ./standalone-metastore/metastore-server/docker/hive-postgres-tpcds-metastore/ | ||
| file: ./standalone-metastore/metastore-server/docker/hive-postgres-tpcds-metastore/Dockerfile | ||
| push: ${{ github.event.inputs.pushImage == 'true' }} | ||
| tags: ${{ github.repository_owner }}/hive-postgres-tpcds-metastore:${{ github.event.inputs.imageTag }} |
|
abstractdog
approved these changes
May 15, 2026
Contributor
abstractdog
left a comment
abstractdog
left a comment
There was a problem hiding this comment.
LGTM, pending tests
currently, there is an unrelated test failure :(
Member
Author
|
Thanks for the review @abstractdog ! The test failure is definitely unrelated so I will not relaunch the tests to save some resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
The CI action publication was tested on my personal user namespace
I also pushed manually from my local env an image to the new apache/hive-postgres-tpcds-metastore namespace:
https://hub.docker.com/repository/docker/apache/hive-postgres-tpcds-metastore