HBASE-30079 Upgrade hbase-compression to use junit5#8168
Merged
liuxiaocs7 merged 2 commits intoapache:branch-2.6from Apr 30, 2026
Merged
HBASE-30079 Upgrade hbase-compression to use junit5#8168liuxiaocs7 merged 2 commits intoapache:branch-2.6from
liuxiaocs7 merged 2 commits intoapache:branch-2.6from
Conversation
Member
liuxiaocs7
commented
Apr 29, 2026
- for branch-2.6
- see: HBASE-30079
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Upgrades the hbase-compression test suite (and related WAL compression tests) to run on JUnit 5/JUnit Platform instead of JUnit 4 / HBase’s JUnit4 templates.
Changes:
- Migrate many compression-related tests from JUnit4 annotations/assertions (
@BeforeClass,@Category,org.junit.Assert, etc.) to JUnit Jupiter (@BeforeAll,@Tag,org.junit.jupiter.api.Assertions, etc.). - Replace HBase’s parameterized test template usage in compressed WAL tests with JUnit-params-style class parameterization annotations.
- Add
junit-jupiter-engineas a test dependency forhbase-compression.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestCompressedWALValueCompression.java | Switch WAL compression test class parameterization annotations toward JUnit 5. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestCompressedWAL.java | Switch WAL provider test class parameterization annotations toward JUnit 5. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/CompressedWALTestBase.java | Convert template-based tests to plain Jupiter @Test methods. |
| hbase-compression/pom.xml | Ensure JUnit Jupiter engine is present to execute Jupiter tests under Maven. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestZstdDictionarySplitMerge.java | Migrate JUnit4 lifecycle/categorization/assertions to JUnit 5. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestZstdDictionary.java | Migrate JUnit4 lifecycle/categorization/assertions to JUnit 5. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestZstdCodec.java | Migrate JUnit4 categorization to JUnit 5 tags. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestZstdByteBuffDecompressor.java | Migrate JUnit4 assertions/categorization to JUnit 5. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestWALCompressionZstd.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestHFileCompressionZstd.java | Migrate JUnit4 lifecycle/categorization/assertions to JUnit 5. |
| hbase-compression/hbase-compression-snappy/src/test/java/org/apache/hadoop/hbase/io/compress/xerial/TestWALCompressionSnappy.java | Migrate JUnit4 lifecycle/categorization/assumptions to JUnit 5. |
| hbase-compression/hbase-compression-snappy/src/test/java/org/apache/hadoop/hbase/io/compress/xerial/TestSnappyCodec.java | Migrate JUnit4 lifecycle/categorization/assumptions to JUnit 5. |
| hbase-compression/hbase-compression-snappy/src/test/java/org/apache/hadoop/hbase/io/compress/xerial/TestHFileCompressionSnappy.java | Migrate JUnit4 lifecycle/categorization/assumptions to JUnit 5. |
| hbase-compression/hbase-compression-lz4/src/test/java/org/apache/hadoop/hbase/io/compress/lz4/TestWALCompressionLz4.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-lz4/src/test/java/org/apache/hadoop/hbase/io/compress/lz4/TestLz4Codec.java | Migrate JUnit4 categorization to JUnit 5 tags. |
| hbase-compression/hbase-compression-lz4/src/test/java/org/apache/hadoop/hbase/io/compress/lz4/TestHFileCompressionLz4.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-brotli/src/test/java/org/apache/hadoop/hbase/io/compress/brotli/TestWALCompressionBrotli.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-brotli/src/test/java/org/apache/hadoop/hbase/io/compress/brotli/TestHFileCompressionBrotli.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-brotli/src/test/java/org/apache/hadoop/hbase/io/compress/brotli/TestBrotliCodec.java | Migrate JUnit4 categorization to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestZstdCodec.java | Migrate JUnit4 categorization to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestWALCompressionZstd.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestWALCompressionSnappy.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestWALCompressionLzo.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestWALCompressionLz4.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestSnappyCodec.java | Migrate JUnit4 categorization to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestLzoCodec.java | Migrate JUnit4 categorization to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestLz4Codec.java | Migrate JUnit4 categorization to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestHFileCompressionZstd.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestHFileCompressionSnappy.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestHFileCompressionLzo.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestHFileCompressionLz4.java | Migrate JUnit4 lifecycle/categorization to JUnit 5. |
Comments suppressed due to low confidence (2)
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestCompressedWALValueCompression.java:1
org.junit.jupiter.params.ParameterizedClass(and class-level@MethodSource) are not part of standard JUnit Jupiter parameterized tests (which are method-based via@ParameterizedTest). As written, this is likely to either not compile (missing annotation type) or to not parameterize the class as intended, which would also interact badly with the change from@TestTemplateto@Testin the base class. Prefer switching the actual test methods to@ParameterizedTest+@MethodSource, or keep using a@TestTemplate-based approach with the appropriate extension/template provider so each parameter set is executed.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestCompressedWALValueCompression.java:1org.junit.jupiter.params.ParameterizedClass(and class-level@MethodSource) are not part of standard JUnit Jupiter parameterized tests (which are method-based via@ParameterizedTest). As written, this is likely to either not compile (missing annotation type) or to not parameterize the class as intended, which would also interact badly with the change from@TestTemplateto@Testin the base class. Prefer switching the actual test methods to@ParameterizedTest+@MethodSource, or keep using a@TestTemplate-based approach with the appropriate extension/template provider so each parameter set is executed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.