HBASE-30079 Upgrade hbase-compression to use junit5#8167
Open
liuxiaocs7 wants to merge 2 commits intoapache:branch-2from
Open
HBASE-30079 Upgrade hbase-compression to use junit5#8167liuxiaocs7 wants to merge 2 commits intoapache:branch-2from
liuxiaocs7 wants to merge 2 commits intoapache:branch-2from
Conversation
Member
liuxiaocs7
commented
Apr 29, 2026
- see: HBASE-30079
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Upgrades the hbase-compression and related WAL compression tests to run on JUnit 5 (Jupiter), replacing JUnit 4 APIs and test categorization patterns.
Changes:
- Migrated multiple compression-related test classes from JUnit 4 (
@Test,@BeforeClass,@Category,Assert/Assume) to JUnit 5 (@Test,@BeforeAll,@Tag,Assertions/Assumptions). - Switched CompressedWAL test infrastructure away from
@TestTemplate/HBase parameterized template toward JUnit 5 parameterization annotations. - Added
junit-jupiter-engineto thehbase-compressionmodule test dependencies.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestCompressedWALValueCompression.java | Replaces HBase parameterized template with JUnit 5 parameterized-class style annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestCompressedWAL.java | Replaces HBase parameterized template with JUnit 5 parameterized-class style annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/CompressedWALTestBase.java | Converts template tests to standard JUnit 5 @Test methods. |
| hbase-compression/pom.xml | Adds junit-jupiter-engine so JUnit 5 tests can execute. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestZstdDictionarySplitMerge.java | Migrates from JUnit 4 to JUnit 5 lifecycle/assertions and replaces categories with tags. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestZstdDictionary.java | Migrates from JUnit 4 to JUnit 5 lifecycle/assertions and replaces categories with tags. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestZstdCodec.java | Migrates from JUnit 4 to JUnit 5 and replaces categories with tags. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestZstdByteBuffDecompressor.java | Migrates from JUnit 4 to JUnit 5 assertions/tags. |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestWALCompressionZstd.java | Migrates from JUnit 4 lifecycle/categories to JUnit 5 (@BeforeAll/@AfterAll, tags). |
| hbase-compression/hbase-compression-zstd/src/test/java/org/apache/hadoop/hbase/io/compress/zstd/TestHFileCompressionZstd.java | Migrates from JUnit 4 lifecycle/categories to JUnit 5 and updates assertions. |
| hbase-compression/hbase-compression-snappy/src/test/java/org/apache/hadoop/hbase/io/compress/xerial/TestWALCompressionSnappy.java | Migrates WAL compression test from JUnit 4 to JUnit 5 assumptions and lifecycle. |
| hbase-compression/hbase-compression-snappy/src/test/java/org/apache/hadoop/hbase/io/compress/xerial/TestSnappyCodec.java | Migrates codec test from JUnit 4 to JUnit 5 assumptions/tags. |
| hbase-compression/hbase-compression-snappy/src/test/java/org/apache/hadoop/hbase/io/compress/xerial/TestHFileCompressionSnappy.java | Migrates HFile test from JUnit 4 to JUnit 5 assumptions/tags/lifecycle. |
| hbase-compression/hbase-compression-lz4/src/test/java/org/apache/hadoop/hbase/io/compress/lz4/TestWALCompressionLz4.java | Migrates WAL compression test from JUnit 4 lifecycle/categories to JUnit 5. |
| hbase-compression/hbase-compression-lz4/src/test/java/org/apache/hadoop/hbase/io/compress/lz4/TestLz4Codec.java | Migrates codec test from JUnit 4 to JUnit 5 tags. |
| hbase-compression/hbase-compression-lz4/src/test/java/org/apache/hadoop/hbase/io/compress/lz4/TestHFileCompressionLz4.java | Migrates HFile test from JUnit 4 lifecycle/categories to JUnit 5 tags/lifecycle. |
| hbase-compression/hbase-compression-brotli/src/test/java/org/apache/hadoop/hbase/io/compress/brotli/TestWALCompressionBrotli.java | Migrates WAL compression test from JUnit 4 lifecycle/categories to JUnit 5. |
| hbase-compression/hbase-compression-brotli/src/test/java/org/apache/hadoop/hbase/io/compress/brotli/TestHFileCompressionBrotli.java | Migrates HFile test from JUnit 4 lifecycle/categories to JUnit 5 tags/lifecycle. |
| hbase-compression/hbase-compression-brotli/src/test/java/org/apache/hadoop/hbase/io/compress/brotli/TestBrotliCodec.java | Migrates codec test from JUnit 4 to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestZstdCodec.java | Migrates codec test from JUnit 4 to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestWALCompressionZstd.java | Migrates WAL compression test from JUnit 4 lifecycle/categories to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestWALCompressionSnappy.java | Migrates WAL compression test from JUnit 4 lifecycle/categories to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestWALCompressionLzo.java | Migrates WAL compression test from JUnit 4 lifecycle/categories to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestWALCompressionLz4.java | Migrates WAL compression test from JUnit 4 lifecycle/categories to JUnit 5. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestSnappyCodec.java | Migrates codec test from JUnit 4 to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestLzoCodec.java | Migrates codec test from JUnit 4 to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestLz4Codec.java | Migrates codec test from JUnit 4 to JUnit 5 tags. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestHFileCompressionZstd.java | Migrates HFile test from JUnit 4 lifecycle/categories to JUnit 5 tags/lifecycle. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestHFileCompressionSnappy.java | Migrates HFile test from JUnit 4 lifecycle/categories to JUnit 5 tags/lifecycle. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestHFileCompressionLzo.java | Migrates HFile test from JUnit 4 lifecycle/categories to JUnit 5 tags/lifecycle. |
| hbase-compression/hbase-compression-aircompressor/src/test/java/org/apache/hadoop/hbase/io/compress/aircompressor/TestHFileCompressionLz4.java | Migrates HFile test from JUnit 4 lifecycle/categories to JUnit 5 tags/lifecycle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.