Skip to content

Correction of the user responsible for the RESOURCE.UPDATE.LIMIT event #13066

Open
GeanJS wants to merge 1 commit intoapache:4.22from
scclouds:duplicated-resource-update-limit
Open

Correction of the user responsible for the RESOURCE.UPDATE.LIMIT event #13066
GeanJS wants to merge 1 commit intoapache:4.22from
scclouds:duplicated-resource-update-limit

Conversation

@GeanJS
Copy link
Copy Markdown

@GeanJS GeanJS commented Apr 23, 2026

Description

Currently, events of the RESOURCE.UPDATE.LIMIT type do not register the user responsible for the performed action. Instead of that, the considered responsible user for the event is the account itself. Changes were made to consider the user responsible for the event as the one that actually performed the event's corresponding action.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

The tests were performed on version 4.22.1.0. In the graphical interface, I updated the resources of an account, and when navigating to the events tab, I was able to verify that the user responsible for the action was properly assigned.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 23, 2026

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this go into 4.22/4.20 branch?

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 18.01%. Comparing base (be89e6f) to head (d1c19dd).
⚠️ Report is 1 commits behind head on 4.22.

Files with missing lines Patch % Lines
.../cloud/resourcelimit/ResourceLimitManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #13066      +/-   ##
============================================
+ Coverage     17.68%   18.01%   +0.33%     
- Complexity    15793    16608     +815     
============================================
  Files          5922     6029     +107     
  Lines        533096   542155    +9059     
  Branches      65209    66451    +1242     
============================================
+ Hits          94275    97684    +3409     
- Misses       428181   433456    +5275     
- Partials      10640    11015     +375     
Flag Coverage Δ
uitests 3.52% <ø> (-0.18%) ⬇️
unittests 19.17% <0.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GeanJS GeanJS force-pushed the duplicated-resource-update-limit branch from dae8f06 to d1c19dd Compare April 24, 2026 11:00
@GeanJS GeanJS changed the base branch from main to 4.22 April 24, 2026 11:00
@bernardodemarco
Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@GeanJS
Copy link
Copy Markdown
Author

GeanJS commented Apr 24, 2026

@shwstppr, These changes do not apply to version 4.20, so I have rebased over 4.22.

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17601

@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants