use 'is not None' for max_nonstreaming_tokens check in timeout calculation#1584
Open
rmotgi1227 wants to merge 1 commit into
Open
use 'is not None' for max_nonstreaming_tokens check in timeout calculation#1584rmotgi1227 wants to merge 1 commit into
rmotgi1227 wants to merge 1 commit into
Conversation
…ation The truthiness guard silently ignored max_nonstreaming_tokens=0, which would mean streaming is always required. Using 'is not None' matches the type annotation (int | None) and makes the intent explicit.
abobakr200023-ship-it
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_calculate_nonstreaming_timeoutuses a truthiness guard onmax_nonstreaming_tokens:The parameter is typed
int | None. Checking truthiness silently skips the guard when the value is0— a value that would mean "streaming is always required regardless of token count." The condition evaluates toFalseand noValueErroris raised.Fix
is not Nonematches the type annotation, makes the intent explicit, and correctly handles a hypotheticalmax_nonstreaming_tokens=0entry inMODEL_NONSTREAMING_TOKENS.