Skip to content

Refactored the autocomplete examples#33136

Draft
tjshiu wants to merge 11 commits intoangular:mainfrom
tjshiu:autcomplete
Draft

Refactored the autocomplete examples#33136
tjshiu wants to merge 11 commits intoangular:mainfrom
tjshiu:autcomplete

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented Apr 24, 2026

Refactored the autocomplete examples to use the new simple-combobox api

  • Also added softDisabled api so that we can keep focus on the input when it is disabled

ok7sai and others added 11 commits April 23, 2026 16:17
…fine behavior

- Adds new examples for simple-combobox: auto-select, highlight, disabled, readonly, and dialog popups.
- Refactors existing datepicker and grid examples for better interaction patterns.
- Introduces alwaysExpanded input to SimpleCombobox for persistent popup states.
- Refines selection behavior in ListboxPattern when followFocus is enabled.
- Cleans up unused inline-suggestion examples and console logs.
- Introduces a 'tabbable' input to Listbox and Tree to control whether the widget or its items are in the tab order.
- Updates ListFocus and Tree behaviors to respect the 'tabbable' signal, defaulting tabIndex to -1 when false.
- Updates simple-combobox examples to set [tabbable]="false" on internal widgets to ensure correct focus behavior.
- Includes unit tests for the new tabbable behavior in ListFocus and Tree.
…tion logic

- Adds extensive unit tests for SimpleCombobox across Listbox, Tree, and Grid implementations.
- Refines aria-autocomplete calculation to exclude dialog-type popups, as they do not support autocomplete behavior.
- Switches SimpleCombobox from pointerdown to click for popup triggering to improve interaction consistency.
- Fixes ListFocus to properly focus the host element when using activedescendant mode.
- Updates GridPattern to prevent resetting its default active state once a user has already interacted with it.
- Moves alwaysExpanded initialization to ngOnInit in the public Combobox component for better lifecycle management.
- Improves simple-combobox-highlight example to handle disabled states.
@pullapprove pullapprove Bot requested review from crisbeto and ok7sai April 24, 2026 02:20
@angular-robot angular-robot Bot added area: build & ci Related the build and CI infrastructure of the project area: aria/combobox area: aria/tree labels Apr 24, 2026
@tjshiu tjshiu marked this pull request as draft April 24, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: aria/combobox area: aria/tree area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants