fix(core): sanitize object keys in deepCopy to prevent prototype pollution#33049
Open
XananasX7 wants to merge 1 commit intoangular:mainfrom
Open
fix(core): sanitize object keys in deepCopy to prevent prototype pollution#33049XananasX7 wants to merge 1 commit intoangular:mainfrom
XananasX7 wants to merge 1 commit intoangular:mainfrom
Conversation
…ution This patch addresses a critical Prototype Pollution vulnerability in the deepCopy utility. By blocking sensitive keys such as __proto__, constructor, and prototype during recursive cloning, we prevent attackers from polluting the global Object.prototype via malicious configuration files (e.g., angular.json). This fix directly mitigates the RCE risk reported in Google Issue Tracker #506079652.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request fixes a critical Prototype Pollution vulnerability in the
deepCopyutility within@angular-devkit/core.Technical Details
The current implementation of
deepCopyrecursively iterates over object properties usingObject.getOwnPropertyNameswithout sanitizing sensitive keys. An attacker can provide a malicious configuration (e.g., inangular.json) containing__proto__,constructor, orprototypekeys to pollute the globalObject.prototype. In Node.js environments, this can lead to Remote Code Execution (RCE) by overwriting inherited properties used by task runners.Fix
Implemented a security check within the recursive loop to skip sensitive keys (
__proto__,constructor,prototype), ensuring the integrity of the prototype chain.Reference: Google Issue Tracker #506079652