feat(@angular/build): add isolate option to unit-test builder#33041
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
feat(@angular/build): add isolate option to unit-test builder#33041clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
Bot
added
detected: feature
clydin
force-pushed
the
feat/vitest-isolate
branch
3 times, most recently
from
39aa7c9 to
9d357a9
Compare
clydin
added
the
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an "isolate" option to the unit test builder, enabling test isolation when using the Vitest runner. The changes span the public API, schema definitions, option normalization, and the Vitest plugin configuration, supported by new unit tests. Review feedback identifies a bug in the validation logic where the default runner is not correctly accounted for, a conflict between isolation and debug modes, and a potential issue where CLI flags might be overridden by user configuration files.
This commit adds an `isolate` option to the `@angular/build:unit-test` builder for the Vitest runner. By default, tests run in a non-isolated environment to match the behavior of Karma/Jasmine. This new option allows developers to easily opt-in to Vitest native isolation (running tests in separate threads or processes) without requiring a custom Vitest configuration file. The option is not supported by the Karma runner and will result in an error if used there.
clydin
force-pushed
the
feat/vitest-isolate
branch
from
9d357a9 to
150c3a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an
isolateoption to the@angular/build:unit-testbuilder for the Vitest runner. By default, tests run in a non-isolated environment to match the behavior of Karma/Jasmine. This new option allows developers to easily opt-in to Vitest native isolation (running tests in separate threads or processes) without requiring a custom Vitest configuration file. The option is not supported by the Karma runner and will result in an error if used there.