test(@angular/build): robustly install @angular/animations in e2e test#33037
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
test(@angular/build): robustly install @angular/animations in e2e test#33037clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
clydin
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the chunk-optimizer-animations E2E test to support Angular snapshot builds by dynamically determining the @angular/animations version based on the environment. A review comment suggests moving the snapshot manifest requirement inside the conditional block to prevent potential runtime errors in environments where the snapshot directory is absent.
alan-agius4
reviewed
Apr 23, 2026
| if (isSnapshotBuild) { | ||
| animationsSpecifier = snapshots.dependencies['@angular/animations']; | ||
| } else { | ||
| const coreJson = JSON.parse(await readFile('node_modules/@angular/core/package.json')); |
Collaborator
There was a problem hiding this comment.
Not: you can use ‘ readNgVersion’
alan-agius4
approved these changes
Apr 23, 2026
Enhance the animations package installation in the E2E test to support snapshot E2E runs by resolving the exact dependency specifier from the ng-snapshot manifest when --ng-snapshots is active. Otherwise, it reads the full installed version of @angular/core directly from the local node_modules to avoid semver issues during package installation.
clydin
force-pushed
the
test/fix-chunk-opt-snapshots
branch
from
467a824 to
9239b1f
Compare
clydin
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the animations package installation in the E2E test to support snapshot E2E runs by resolving the exact dependency specifier from the ng-snapshot manifest when --ng-snapshots is active. Otherwise, it reads the full installed version of @angular/core directly from the local node_modules to avoid semver issues during package installation.