[Aikido] Fix security issue in axios via minor version upgrade from 1.15.1 to 1.16.1#1690
Open
aikido-autofix[bot] wants to merge 2 commits into
Open
[Aikido] Fix security issue in axios via minor version upgrade from 1.15.1 to 1.16.1#1690aikido-autofix[bot] wants to merge 2 commits into
aikido-autofix[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade axios to fix confidentiality breach in HTTPS proxy handling, enforce response size limits in fetch adapter, prevent prototype pollution in form data parsing, and fix regex DoS in cookie parsing.
✅ Code not affected by breaking changes.
✅ No breaking changes from the axios upgrade affect this codebase.
The codebase uses axios in three locations:
packages/constructs/header-change-detection/lib/lambda/header-check.ts- usesaxios.get()withvalidateStatusoptionpackages/constructs/prerender-proxy/lib/handlers/error-response.ts- usesaxios.create()withtimeout,maxRedirects,validateStatus, andhttpsAgentoptionspackages/constructs/prerender-fargate/lib/recaching/prerender-recache-api-construct.consumer.ts- usesaxios.get()withheadersandvalidateStatusoptionsNone of the breaking changes apply:
Fetch adapter limits: No custom adapter is configured, and
maxBodyLength/maxContentLengthare not set anywhereBasic auth in URLs: No URLs with embedded credentials (format
user:pass@host) were foundparseProtocol: This internal function is not used directly in the codebase
URL encoding changes: No evidence of reliance on legacy
unescape()behavior or non-ASCII URL handlingAll breaking changes by upgrading axios from version 1.15.1 to 1.16.1 (CHANGELOG)
maxBodyLengthandmaxContentLengthlimits that were previously silently ignoredparseProtocolnow strictly requires a colon in the protocol separator; strings that loosely parsed as protocols before may no longer matchunescape()replaced with modern UTF-8 encoding; non-ASCII URL handling may produce different output bytes for consumers depending on legacyunescape()quirks✅ 4 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
formDataToJSONhelper allows attackers to polluteObject.prototypethrough specially crafted multipart field names, potentially enabling remote code execution or other malicious actions.