You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my use case, I'm showing a calendar for events that happen in a particular timezone, which might not be the same as the user's current timezone, so I added the ability to set the timezone on the WeekView object.
Calendar objects (of the WeekViewEvent class) are more than capable of handling the timezones. You can manipulate the timezone of events to make them appear in week view in whatever timezone you want. Why should the timezone be an attribute of the view itself?
Well, at least one reason is because the setShowNowLine is then going to show the wrong place on the timeline. Another reason is that goToToday won't work properly across days (e.g. it's already tomorrow in Korea, so if the event is in Korea and the user is in San Francisco, then goToToday should really go to my home timezone's "tomorrow".
It's OK with me if you don't want to accept the pull request, since I was able to make the changes and they work well for my own app. I just thought it might be useful to others. Great work, btw, this is a very helpful library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my use case, I'm showing a calendar for events that happen in a particular timezone, which might not be the same as the user's current timezone, so I added the ability to set the timezone on the WeekView object.