BigramDetector#149
Open
ernstleierzopf wants to merge 17 commits into
Open
Conversation
Contributor
Author
|
@viktorbeck98 could you please review the code and make suggestions specifically to the persistency of the class? How is the data persisted and loaded? Do I have to somehow add self.freq and self.total_freq to the persistency class? I do not really know if it works as it should and it should be treated as a first implementation; further testing is required. |
Resolved conflicts in config/pipeline_config_default.yaml and docs/detectors.md by keeping both BigramFrequencyDetector and CharsetDetector entries.
…cker Adds an opaque Dict[str, Any] field that detectors can use to stash per-variable model state across save/load cycles, with full round-trip support via to_state()/from_state() and backward-compatible defaults. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Intermediate commit — train/detect rewrites land in subsequent commits. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…cy object Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nce drops Rewrites train/train_helper so bigrams are computed for all configured variables (not just pre-existing ones), fixing the first-occurrence drop for new EventIDs. Snapshots unique_set before ingest so skip_repetitions correctly skips repeats without skipping first occurrences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60