chore(spawn-docker-jdk): replace Jackson with base-json#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
jackson-coreandjackson-databindfromspawn-dockerandspawn-docker-jdk, replacing them withbase-json(base 0.24.0). TheDockerOptioninterface is redesigned as a sealed hierarchy of plain data holders — serialization is now done entirely insideCreateContainervia an exhaustive pattern-matching switch, so any new permitted subtype is caught at compile time rather than at runtime.JsonNodeInputStreamProcessoris simplified to a straightforward NDJSON line reader. Model classes (AbstractJsonBasedResultand its subclasses) are migrated toJsonValuewith small navigation helpers (at,text,longAt,boolAt). Three bugs introduced during the migration are fixed:text()now returns""for JSON null nodes (not the string"null");publishedPorts()andlinks()now guard against a JSON null node withinstanceofpattern matching instead of callingasObject()/asArray()unconditionally; andpid()correctly restores-1Las the sentinel for an absent PID. Regression tests are added for all three.