Support Per-app language preferences by 314systems · Pull Request #579 · VREMSoftwareDevelopment/WiFiAnalyzer

314systems · 2025-12-29T08:18:55Z

Summary

Support Per-app language preferences

What does this implement/fix?

Support Per-app language preferences.

Does this close any issues?

Closes [Feature] Support Per-app language preferences #577

How was this tested?

Devices / OS (e.g. Android 13 emulator, Pixel 6): Android 16 emulator
Platform / Build variant (e.g. debug/release): debug
Toolchain / Gradle / SDK version(s): 36.1.0, 8.14.2, 36
Steps to reproduce / test (provide exact steps so reviewers can verify):

Example test commands:

./gradlew ktlintCheck

Checklist (required before marking ready)

I added or updated unit tests (see app/src/test/)
I followed the project's coding style (ktlint) and formatting
I ran lint and addressed or documented any warnings
CI checks pass (unit tests, coverage, lint)
No sensitive data, keys, or secrets are included

Additional context

Screenshots, logs, or other context that helps reviewers understand the change.
Migration notes or compatibility considerations (if applicable).

Copilot

Pull request overview

This PR implements per-app language preferences by migrating from a custom locale management approach to Android's native AppCompatDelegate API. The changes align with Android's modern language preference system introduced in API 33+, enabling users to select a language specifically for this app independent of the system language.

Key changes:

Migrated from manual context creation with custom locale to AppCompatDelegate.setApplicationLocales()
Removed language change tracking from MainReload since AppCompat handles activity recreation automatically
Updated locale utility functions to use BCP-47 language tags and improved Chinese locale handling with script-based differentiation

Reviewed changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
app/src/main/kotlin/com/vrem/wifianalyzer/MainActivity.kt	Removed attachBaseContext override; added onSharedPreferenceChanged logic to handle language changes via AppCompatDelegate; added syncLanguage call in onCreate
app/src/main/kotlin/com/vrem/wifianalyzer/MainReload.kt	Removed language locale tracking since AppCompat handles locale changes automatically
app/src/main/kotlin/com/vrem/wifianalyzer/settings/Settings.kt	Replaced languageLocale() with appLocale() using AppCompatDelegate.getApplicationLocales(); added syncLanguage() method
app/src/main/kotlin/com/vrem/wifianalyzer/settings/LanguagePreference.kt	Updated to support "System default" option with empty string tag; refactored data() to accept Context
app/src/main/kotlin/com/vrem/wifianalyzer/settings/CountryPreference.kt	Updated method call from languageLocale() to appLocale(); renamed utility function reference
app/src/main/kotlin/com/vrem/wifianalyzer/wifi/channelavailable/ChannelAvailableFragment.kt	Updated method call from languageLocale() to appLocale()
app/src/main/kotlin/com/vrem/wifianalyzer/vendor/model/VendorService.kt	Changed uppercase() to use Locale.ROOT for locale-independent string operations
app/src/main/kotlin/com/vrem/util/LocaleUtils.kt	Major refactor: added BCP-47 language tag support, improved Chinese locale handling with script detection, renamed functions for clarity, removed legacy underscore format generation
app/src/main/kotlin/com/vrem/util/CompatUtils.kt	Removed createContext() extension function no longer needed with AppCompat
app/src/main/kotlin/com/vrem/util/StringUtils.kt	Added titlecaseFirst() extension function for proper title casing of locale display names
app/src/main/AndroidManifest.xml	Added AppLocalesMetadataHolderService configuration with autoStoreLocales enabled
app/src/main/res/resources.properties	Added unqualifiedResLocale=en-US to specify base locale for resources
app/build.gradle	Added generateLocaleConfig=true for automatic locale configuration generation
app/src/main/res/values*/strings.xml	Added "system_default" string translations in all supported languages
app/src/test/kotlin/*/Test.kt	Updated tests to reflect API changes: renamed method calls, updated locale handling tests, removed language tracking tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

VREMSoftwareDevelopment · 2026-01-02T15:32:09Z

This is a promising improvement, but it does introduce some compatibility considerations.

Per‑app language support is only native on Android 13+ (API 33). Since WiFiAnalyzer still supports API 24+, devices on API 24–32 rely on AppCompat’s fallback implementation, which can behave differently across OEMs and Android versions. This may affect Activity recreation, UI stability, and how reliably the selected language is applied.

To ensure a smooth transition for all users, this change would benefit from broader testing on real devices in addition to emulator checks, especially across older API levels. It may also be worth considering whether this migration is better aligned with a future release where support for older Android versions is reduced.

Could you also share which devices and API levels you tested this on? That would help us better understand the current coverage and identify any gaps.

VREMSoftwareDevelopment · 2026-04-22T15:51:15Z

Thank you for the contribution.
The CI pipeline is failing because this change reduces code coverage.
The project requires that coverage does not decrease, so additional unit tests are needed for the new or modified logic.
Please update the PR with the necessary tests so the coverage check can pass.

VREMSoftwareDevelopment

#579 (comment)

Thank you for the contribution.
The CI pipeline is failing because this change reduces code coverage.
The project requires that coverage does not decrease, so additional unit tests are needed for the new or modified logic.
Please update the PR with the necessary tests so the coverage check can pass.

314systems · 2026-05-03T13:34:23Z

Thank you for the review, and sorry for the late reply.

At the moment, I’m not able to dedicate sufficient time to Android development. If possible, I would appreciate it if you could allow me some time until the end of May to add the necessary tests and address the coverage issue.

Thank you for your understanding.

VREMSoftwareDevelopment · 2026-05-03T13:56:06Z

@314systems

No problem. Please take whatever time you need, and feel free to update the PR when you're ready.

codecov · 2026-05-04T06:06:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.84%. Comparing base (e3b385e) to head (55975dc).

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #579      +/-   ##
============================================
+ Coverage     97.83%   97.84%   +0.01%     
- Complexity      975      980       +5     
============================================
  Files           121      121              
  Lines          2581     2603      +22     
  Branches        211      222      +11     
============================================
+ Hits           2525     2547      +22     
  Misses           19       19              
  Partials         37       37

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+private fun data(context: Context): List<Data> =
+    supportedLanguageTags().map { tag ->
+        if (tag.isEmpty()) {
+            Data("", context.getString(R.string.system_default))
+        } else {
+            val locale = Locale.forLanguageTag(tag)
+            Data(tag, locale.getDisplayName(locale).titlecaseFirst(locale))
+        }
+    }



+        fixture.onSharedPreferenceChanged(sharedPreferences, languageKey)
+        // validate
+        verify(scannerService).update()
+        assertThat(AppCompatDelegate.getApplicationLocales().toLanguageTags()).isEqualTo(languageTag)
+    }


add tests for titlecaseFirst extension function in StringUtilsTest

…ales

…cales

…vity

314systems · 2026-05-05T09:23:20Z

maybe done

314systems force-pushed the lang branch 2 times, most recently from 4d2ae95 to 286c209 Compare January 1, 2026 09:06

314systems marked this pull request as ready for review January 1, 2026 09:25

Copilot AI review requested due to automatic review settings January 1, 2026 09:25

Copilot started reviewing on behalf of 314systems January 1, 2026 09:25 View session

Copilot AI reviewed Jan 1, 2026

View reviewed changes

314systems marked this pull request as draft January 3, 2026 13:23

314systems marked this pull request as ready for review February 24, 2026 11:57

VREMSoftwareDevelopment added the AI assistance used Indicates that an AI assistant was used to generate this PR label Apr 22, 2026

VREMSoftwareDevelopment self-requested a review May 3, 2026 13:27

VREMSoftwareDevelopment requested changes May 3, 2026

View reviewed changes

VREMSoftwareDevelopment requested a review from Copilot May 4, 2026 12:26

Copilot started reviewing on behalf of VREMSoftwareDevelopment May 4, 2026 12:26 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

314systems force-pushed the lang branch 2 times, most recently from 63d74c6 to 90ad6a6 Compare May 5, 2026 06:02

314systems added 9 commits May 5, 2026 15:23

enable locale config generation

f5ba099

add AppLocalesMetadataHolderService to manifest

e1172e6

refactor LocaleUtils and update settings references

b672093

add system_default string to translations

49d205d

update locale utils and language preference

e17243c

add tests for titlecaseFirst extension function in StringUtilsTest

refactor locale handling to use AppCompatDelegate for application loc…

353cfa0

…ales

update LocaleUtils and refactor language preference tests

960d7dd

reorder and update supported locales in LocaleUtils and LocaleUtilsTest

f6db85d

rename variable

c83cba2

314systems added 6 commits May 5, 2026 15:23

remove createContext from CompatUtils and CompatUtilsTest

3fbc740

add support for Chinese language tags and update tests

2dce2a1

update SettingsTest with appLocale and syncLanguage tests

391da3b

refactor LocaleUtils to use a getter for countriesLocales

0da39a1

refactor LocaleUtils to extract findSupportedLocale method

c72e3e4

add tests for locale matching logic in LocaleUtils

afbf046

314systems force-pushed the lang branch from 90ad6a6 to afbf046 Compare May 5, 2026 06:24

314systems added 2 commits May 5, 2026 15:46

add tests for language preference change handling with application lo…

d70b542

…cales

register and unregister shared preference change listener in MainActi…

55975dc

…vity

314systems requested a review from VREMSoftwareDevelopment May 7, 2026 00:34

Conversation

314systems commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What does this implement/fix?

Does this close any issues?

How was this tested?

Checklist (required before marking ready)

Additional context

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VREMSoftwareDevelopment commented Jan 2, 2026

Uh oh!

VREMSoftwareDevelopment commented Apr 22, 2026

Uh oh!

VREMSoftwareDevelopment left a comment

Choose a reason for hiding this comment

Uh oh!

314systems commented May 3, 2026

Uh oh!

VREMSoftwareDevelopment commented May 3, 2026

Uh oh!

codecov Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

314systems commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

314systems commented Dec 29, 2025 •

edited

Loading

codecov Bot commented May 4, 2026 •

edited

Loading