Skip to content

fix: use SAVE_AND_APPLY instead of SAVE_AND_FORCE_APPLY in BOSer set_power_limit#421

Draft
maroun2 wants to merge 2 commits intoUpstreamData:masterfrom
maroun2:bosminer-api-power-target
Draft

fix: use SAVE_AND_APPLY instead of SAVE_AND_FORCE_APPLY in BOSer set_power_limit#421
maroun2 wants to merge 2 commits intoUpstreamData:masterfrom
maroun2:bosminer-api-power-target

Conversation

@maroun2
Copy link
Copy Markdown

@maroun2 maroun2 commented Apr 27, 2026

Summary

  • Change SaveAction.SAVE_AND_FORCE_APPLY to SaveAction.SAVE_AND_APPLY in BOSer.set_power_limit()
  • SAVE_AND_FORCE_APPLY restarts bosminer to apply the power target, which is disruptive and unnecessary
  • SAVE_AND_APPLY applies the power target immediately without restarting bosminer

Test plan

  • Call set_power_limit() on a BOSer miner and verify power target is applied without bosminer restart
  • Verify the new power target persists across reboots (save behavior unchanged)

…PPLY for immediate effect without restart bosminer
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 27, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

S19 Pro Hydro was missing from the BRAIINS_OS model map in the factory,
causing it to be detected as "Unknown (BOS+)" despite the API reporting
the correct model name. Added BOSMinerS19ProHydro class and registered
both "ANTMINER S19 PRO HYD." and "ANTMINER S19 PRO HYDRO" variants.
@maroun2 maroun2 marked this pull request as draft April 27, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants