Use websocket bridge for snapshot and pedalboard change events#141
Open
sastraxi wants to merge 25 commits intoTreeFallSound:pistomp-v3from
Open
Use websocket bridge for snapshot and pedalboard change events#141sastraxi wants to merge 25 commits intoTreeFallSound:pistomp-v3from
sastraxi wants to merge 25 commits intoTreeFallSound:pistomp-v3from
Conversation
# Conflicts: # modalapi/mod.py
# Conflicts: # modalapi/websocket_bridge.py
At startup self.current can be None before the first pedalboard loads, causing a crash if the pedalboard monitor fires before initialization is complete.
# Conflicts: # modalapi/modhandler.py
sastraxi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than loading
last.jsonand detecting modification time changes, we can load the current pedalboard using the REST API on startup (mod-ui starts before pistomp) and then track pedalboard changes using websocket messages.We still use the polling loop for mod-ui changes, but instead of checking the file, we check for queued messages from mod-ui on the websocket since the last time we checked.
Bonus: we can actually read snapshot changes this way too, so this PR also adds that feature to sync the current snapshot if changed in MOD-UI.
Branch stack